Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ~ that people keep putting in the system variable #224

Merged
merged 4 commits into from
Jul 6, 2024

Conversation

JMM889901
Copy link
Contributor

if this actually needed, just close this, I have heard mixed things about including the ~ not working

if this actually needed just close this, i have heard mixed things about including the ~ not working
@JMM889901
Copy link
Contributor Author

womp

@GeckoEidechse
Copy link
Member

I don't have an affected CPU to test this. If anyone with an affected CPU could test this and report back whether the change is correct so that I can merge or close, that'd be great ^^

@itscynxx
Copy link
Contributor

i've hopefully got someone (righthonorable on the Discord server) testing this over the weekend, but if anyone else wants to do it sooner feel free to

@LumiKattlin
Copy link

Tested on my pc with a 12th gen and without the ~ it worked for me

Copy link
Contributor

@itscynxx itscynxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless Linux works differently than this

docs/installing-northstar/troubleshooting.md Outdated Show resolved Hide resolved
@itscynxx
Copy link
Contributor

itscynxx commented Oct 4, 2023

Requested changes have been made, and the guide has been tested to work without the ~ in it

@GeckoEidechse
Copy link
Member

GeckoEidechse commented Dec 30, 2023

Wait, so both the version with and without the ~ work? Or just the one without?

@itscynxx
Copy link
Contributor

itscynxx commented Jan 4, 2024

Wait, so both the version with and without the ~ work? Or just the one without?

Lumi tested it and says it worked, I've recommended it to a few users and it's worked for them as well

Additionally, I'll have a 12th gen I'll put together tonight instead of waiting. Can test myself later as long as I don't skill issue and break something

@itscynxx
Copy link
Contributor

itscynxx commented Jan 6, 2024

Just tested.

On Northstar, I didn't need to set anything to get in game. Installed my i7 12700kf yesterday, didn't touch variables, and was able to connect normally

On vanilla I did have the issue tho. Worked perfectly fine without the ~

@pg9182
Copy link
Member

pg9182 commented Jan 6, 2024

For the record, ~0x20000000 clears the 29th bit of the result from cpuid, while 0x20000000 replaces the result with one with just the 29th bit set (OPENSSL_ia32cap.3). The 29th bit represents the Intel SHA Extensions.

As such, if the second one (without the ~) works, the actual solution has nothing to do with the 29th bit; it's one of the others.

@itscynxx
Copy link
Contributor

Should be noted that this works more often than with the tilda
Another example of removing the tilda fixing the issue (whereas with the tilda, it didnt fix the connecting issue): https://discord.com/channels/920776187884732556/1102373220121845880/1210782379304689664

@GeckoEidechse
Copy link
Member

@GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse merged commit a69afc5 into R2Northstar:main Jul 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants