-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to vanilla profile section #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like the change. A few technicalities to address then we should be good to merge ^^
To be honest, Northstar without core mods is a little unplayable currently due to the rpc spam in console, without even getting into the entire modsetings being missing thing (and having no replacement other than vanilla+ now that mod settings is blacklisted; which is a very good thing, don't get me wrong, it just means that one small, specific sub section of Northstar becomes less compatible for the majority to become much much more compatible, which I'm all for) I also don't find it particularly right for me to write a section shilling vanilla+ without some kind of green light At the very least 2 electric boogaloo, imo this shouldn't get merged until at least plugins v3 where vanilla has playable framerates from rpc being fixed |
Aight, setting to draft then in the meantime. |
With plugins v3, vanilla is (or at least should be, I haven't explicitly checked) playable again with no core mods (without making a dummy mod or using vanilla+ to stop the spam), so I think this is ready to be reviewed again |
I'm going to close this due the changes being made in terms of vanilla compatibility I'll create a separate pr with updated information when it's relevant, instead of having this merged and having another pr to update it again merged (hopefully) not too soon after |
This has become a very common question in recent days, decided I wanted to make this clearer to make a tag for it