Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for faceting and formula_override problems #171

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

LMBradford
Copy link
Collaborator

These commits stop the analysis from breaking if

  • the formula_override config parameter is null
  • facets parameter is null
  • the facet value(s) aren't in the contrasts file (ex. facets are "A" and "B"; current code requires that the contrasts be something like:
    A_10 A_0

@LMBradford
Copy link
Collaborator Author

This needs to be merged before changes in the validation branch will work properly.

Copy link
Contributor

@mattjmeier mattjmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@LMBradford LMBradford merged commit b8c0274 into main Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants