Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord: implement force proxied emoji (resolves #11) #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Lunaphied
Copy link
Collaborator

This adds a new feature to Séance where reference user reactions of emoji can automatically be proxied. Any emoji provided by the proxied-emoji config value will be proxied.

This removes the ability of the reference user to react with those emoji and is primarily assumed to be used for things like custom heart reactions that are unique per-user, making their usage easier.

The valid config value is a comma or whitespace separated list of unicode emoji and Discord custom emoji IDs that should be handled this way. * may also be used to indicate that all reactions by the reference user should be proxied.

This commit also revises the README to more clearly list the available configuration options.

@Lunaphied Lunaphied force-pushed the feature/forced-emoji branch from 529d2f9 to 8b38093 Compare July 8, 2024 19:19
@Lunaphied Lunaphied requested a review from Qyriad July 8, 2024 19:19
@Lunaphied Lunaphied force-pushed the feature/forced-emoji branch 3 times, most recently from 02bb778 to 5b5262e Compare July 8, 2024 19:23
This adds a new feature to Séance where reference user reactions of
emoji can automatically be proxied. Any emoji provided by the
`proxied-emoji` config value will be proxied.

This removes the ability of the reference user to react with those emoji
and is primarily assumed to be used for things like custom heart
reactions that are unique per-user, making their usage easier.

The valid config value is a comma or whitespace separated list of
unicode emoji and Discord custom emoji IDs that should be handled this
way. `*` may also be used to indicate that *all* reactions by the
reference user should be proxied.

This commit also revises the README to more clearly list the available
configuration options.
@Lunaphied Lunaphied force-pushed the feature/forced-emoji branch from 5b5262e to 4547b6a Compare July 8, 2024 19:26
@@ -744,6 +741,61 @@ async def on_presence_update(self, _before: Member, after: Member):
self._cached_status = status


# Needs to be raw because message might not be in the message cache.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not use self._refetch_message()?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an event handler, it simply won't be called at all (we tried it), personally it seems like a bit of an odd choice but that's a discord.py choice

seance/discord_bot/__init__.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants