Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic starter #7080

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add basic starter #7080

wants to merge 1 commit into from

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Nov 21, 2024

What is it?

  • Feature / enhancement
  • Infra

Description

This is a bit simpler version of the playground starter app (without the extra routes and some components)

Checklist

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 7f303f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gioboa
Copy link
Member

gioboa commented Nov 21, 2024

Can we replace the empty one with this? More starters means more things to maintain, this is my only concern

@shairez
Copy link
Contributor Author

shairez commented Nov 21, 2024

Can we replace the empty one with this? More starters means more things to maintain, this is my only concern

Well I think the empty is good as it is - because the others have fonts, styles and components that you need to remove (even the basic)

We can discuss it further in the next meeting to sync up before we merge this

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to me 👍
Thanks @shairez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants