Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha recognisers for pippit, bittern & cisticola #323

Merged
merged 18 commits into from
Jun 12, 2020

Conversation

towsey
Copy link
Contributor

@towsey towsey commented Jun 12, 2020

Issue #321

To merge latest four recognizers into master

Changes

All the four recognizers have the same general architecture and same structure to config.yml files

Issues

New functionality.
Have done some new unit tests

Visual Changes

Final Checklist

towsey added 16 commits June 1, 2020 15:09
Issue #321 THis recognizer with current config has zero errors on this config where db threshold= 6.0. When threshold db = 3.0 get four FPs.
Issue #321 THis recognizer now works on a single example file used for unit test purposes. Has not been tested on the noise dataset.
Issue #321 The yml file for this recognizer has not yet been edited for parameter values. I.e. only set up the architecture.
Issue #321 Transfer some post-processing steps from specific recognizer to GenericRecognizer class
Issue #321 Do last work on Australiasian Pipit.
Getting large number of FPs i.e. 280 in 90 noise filoes. But this will have to be sorted doing post-processing on the event content.
Issue #321 Write new method to combine the acoustic tracks in a composite event.
Issue #321 Finish work on Australasian Pipit recognizer. THis recognizer still has a FP rate of 60 on the noise data set. THis can be improved with better characterisation of the event content.

NOTE WARNING @ line 350 in EventExtentions.cs
Issue #321 Remove commented code.
Issue #321 Establish rewasonable parameters for the generic component and establish sequence of filters with their parameters.
THis recognizer has some 200 FPs on the noise data set. THis is high but will have to be whittled down using the content of the events.
Issue #321 Remove lower neighbourhood because the Cisticola call includes some lower components that are not captured by the current recognizer.
Issue #321 Changes to parameter values in config files require adjustments to unit test results.
Issue #321 Write two tests for matrix concatenation
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #323 into master will increase coverage by 28.45%.
The diff coverage is 79.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #323       +/-   ##
===========================================
+ Coverage    0.72%   29.18%   +28.45%     
===========================================
  Files         471      474        +3     
  Lines       50388    68728    +18340     
===========================================
+ Hits          367    20059    +19692     
+ Misses      50021    48669     -1352     
Impacted Files Coverage Δ
.../AudioAnalysisTools/Events/Types/CompositeEvent.cs 68.39% <ø> (+68.39%) ⬆️
...AnalysisPrograms/Recognizers/Birds/NinoxBoobook.cs 39.28% <41.66%> (+39.28%) ⬆️
...rograms/Recognizers/Birds/AnthusNovaeseelandiae.cs 69.73% <69.73%> (ø)
...rograms/Recognizers/Birds/BotaurusPoiciloptilus.cs 86.95% <83.33%> (+86.95%) ⬆️
...lysisPrograms/Recognizers/Birds/CisticolaExilis.cs 84.21% <84.21%> (ø)
src/TowseyLibrary/MatrixTools.cs 25.39% <86.66%> (+25.39%) ⬆️
.../AnalysisPrograms/Recognizers/GenericRecognizer.cs 77.37% <100.00%> (+77.37%) ⬆️
src/AudioAnalysisTools/Events/EventExtentions.cs 73.82% <100.00%> (+73.82%) ⬆️
.../AudioAnalysisTools/Tracks/UpwardTrackAlgorithm.cs 98.33% <100.00%> (+98.33%) ⬆️
src/AED/Matlab.fs 87.87% <0.00%> (-1.02%) ⬇️
... and 459 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c288b...f8545f0. Read the comment docs.

Copy link
Member

@atruskie atruskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly this PR needs to remove noisy/duplicated code. On the whole, great work.

towsey and others added 2 commits June 12, 2020 22:18
Update src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.AnthusNovaeseelandiae.yml

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.BotaurusPoiciloptilus.yml

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.CisticolaExilis.yml

Co-authored-by: Anthony Truskinger <[email protected]>

Update tests/Acoustics.Test/AnalysisPrograms/Recognizers/AustBitternTests.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update tests/Acoustics.Test/AnalysisPrograms/Recognizers/AustralPipitTests.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisPrograms/Recognizers/Birds/AnthusNovaeseelandiae.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisPrograms/Recognizers/Birds/AnthusNovaeseelandiae.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisPrograms/Recognizers/Birds/CisticolaExilis.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisPrograms/Recognizers/Birds/CisticolaExilis.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisPrograms/Recognizers/Birds/CisticolaExilis.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisPrograms/Recognizers/Birds/BotaurusPoiciloptilus.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisPrograms/Recognizers/Birds/NinoxBoobook.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update src/AnalysisPrograms/Recognizers/Birds/AnthusNovaeseelandiae.cs

Co-authored-by: Anthony Truskinger <[email protected]>

Update AnthusNovaeseelandiae.cs

Issue #321 Removed unused method.
@atruskie atruskie force-pushed the Issue321_TwoRecognizers branch from 14e041d to f8545f0 Compare June 12, 2020 12:19
@atruskie atruskie changed the title Issue321 two recognizers Alpha recognisers for pippit, bittern & cisticola Jun 12, 2020
@atruskie atruskie closed this Jun 12, 2020
@atruskie atruskie reopened this Jun 12, 2020
@atruskie atruskie merged commit a9d94d2 into master Jun 12, 2020
@atruskie atruskie deleted the Issue321_TwoRecognizers branch June 12, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants