-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha recognisers for pippit, bittern & cisticola #323
Conversation
Issue #321 THis recognizer with current config has zero errors on this config where db threshold= 6.0. When threshold db = 3.0 get four FPs.
Issue #321 THis recognizer now works on a single example file used for unit test purposes. Has not been tested on the noise dataset.
Issue #321 The yml file for this recognizer has not yet been edited for parameter values. I.e. only set up the architecture.
Issue #321 Transfer some post-processing steps from specific recognizer to GenericRecognizer class
Issue #321 Do last work on Australiasian Pipit. Getting large number of FPs i.e. 280 in 90 noise filoes. But this will have to be sorted doing post-processing on the event content.
Issue #321 Write new method to combine the acoustic tracks in a composite event.
Issue #321 Finish work on Australasian Pipit recognizer. THis recognizer still has a FP rate of 60 on the noise data set. THis can be improved with better characterisation of the event content. NOTE WARNING @ line 350 in EventExtentions.cs
Issue #321 Remove commented code.
Issue #321 Establish rewasonable parameters for the generic component and establish sequence of filters with their parameters. THis recognizer has some 200 FPs on the noise data set. THis is high but will have to be whittled down using the content of the events.
Issue #321 Remove lower neighbourhood because the Cisticola call includes some lower components that are not captured by the current recognizer.
Issue #321 Changes to parameter values in config files require adjustments to unit test results.
Issue #321 Write two tests for matrix concatenation
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
===========================================
+ Coverage 0.72% 29.18% +28.45%
===========================================
Files 471 474 +3
Lines 50388 68728 +18340
===========================================
+ Hits 367 20059 +19692
+ Misses 50021 48669 -1352
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly this PR needs to remove noisy/duplicated code. On the whole, great work.
src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.AnthusNovaeseelandiae.yml
Show resolved
Hide resolved
src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.AnthusNovaeseelandiae.yml
Outdated
Show resolved
Hide resolved
src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.BotaurusPoiciloptilus.yml
Outdated
Show resolved
Hide resolved
src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.CisticolaExilis.yml
Outdated
Show resolved
Hide resolved
tests/Acoustics.Test/AnalysisPrograms/Recognizers/AustBitternTests.cs
Outdated
Show resolved
Hide resolved
tests/Acoustics.Test/AnalysisPrograms/Recognizers/AustralPipitTests.cs
Outdated
Show resolved
Hide resolved
Update src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.AnthusNovaeseelandiae.yml Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.BotaurusPoiciloptilus.yml Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisConfigFiles/RecognizerConfigFiles/Towsey.CisticolaExilis.yml Co-authored-by: Anthony Truskinger <[email protected]> Update tests/Acoustics.Test/AnalysisPrograms/Recognizers/AustBitternTests.cs Co-authored-by: Anthony Truskinger <[email protected]> Update tests/Acoustics.Test/AnalysisPrograms/Recognizers/AustralPipitTests.cs Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisPrograms/Recognizers/Birds/AnthusNovaeseelandiae.cs Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisPrograms/Recognizers/Birds/AnthusNovaeseelandiae.cs Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisPrograms/Recognizers/Birds/CisticolaExilis.cs Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisPrograms/Recognizers/Birds/CisticolaExilis.cs Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisPrograms/Recognizers/Birds/CisticolaExilis.cs Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisPrograms/Recognizers/Birds/BotaurusPoiciloptilus.cs Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisPrograms/Recognizers/Birds/NinoxBoobook.cs Co-authored-by: Anthony Truskinger <[email protected]> Update src/AnalysisPrograms/Recognizers/Birds/AnthusNovaeseelandiae.cs Co-authored-by: Anthony Truskinger <[email protected]> Update AnthusNovaeseelandiae.cs Issue #321 Removed unused method.
14e041d
to
f8545f0
Compare
Issue #321
To merge latest four recognizers into master
Changes
All the four recognizers have the same general architecture and same structure to config.yml files
Issues
New functionality.
Have done some new unit tests
Visual Changes
Final Checklist