Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DownloadTargetMetaFileTask when meta file is unavailable #669

Open
wants to merge 1 commit into
base: 1.21.4-pre2
Choose a base branch
from
Open

fix DownloadTargetMetaFileTask when meta file is unavailable #669

wants to merge 1 commit into from

Conversation

supersaiyansubtlety
Copy link
Contributor

fixes https://github.com/QuiltMC/quilt-mappings/actions/runs/12044298644/job/33581079167#step:6:595

Note: This is just a quick fix, I'll make a PR that improves upon it:

  • DownloadTargetMetaFileTask could be converted to a ValueSource
  • we could maybe ping the url instead of just trying to download and catching the exception if it fails

@supersaiyansubtlety supersaiyansubtlety added bug something isn't working correctly v: snapshot targets a snapshot version of minecraft reviews needed please review this PR s: tiny PRs with less than 50 lines labels Nov 27, 2024
@supersaiyansubtlety supersaiyansubtlety self-assigned this Nov 27, 2024
@supersaiyansubtlety supersaiyansubtlety added the t: toolchain changes to the quilt mappings toolchain label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@supersaiyansubtlety supersaiyansubtlety

Labels
bug something isn't working correctly reviews needed please review this PR s: tiny PRs with less than 50 lines t: toolchain changes to the quilt mappings toolchain v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@supersaiyansubtlety