Add support for calling the invoicing API #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream changes
Pull upstream
|
Thanks for the pull request. Do you mind writing a test case scenario for the change, so we avoid problems in future releases? |
|
@Sthing What about introducing a new class for the Invoicing API so the resulting end code will be more clear? And that class utilize the client with the url? |
|
@Sthing What is your take on my suggestion for introducing another class for starting up the Invoice API? |
|
@lsolesen Ehm - I think it is ok, but I don't have the time to do it right now. |
|
Not sure this is still relevant. i made this solution, so i dont have to deal with multiple classes, since the only difference is the api endpoint. The rest is the same and therefore no need for another class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.