Wrap all JavaScript in an Immediately-Invoked Function Expression

[DemiMarie]

This ensures that variables declared in the script do not alter the enclosing scope. Yes, JavaScript is a bad language.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025010404-4.3&flavor=pull-requests

Test run included the following:

• updater: make UpdateListIter a proper iterator qubes-desktop-linux-manager#238 (QubesOS/qubes-desktop-linux-manager@1231efc)
• Don't rely on kdelibs #20 (997a5a3)
• Remove deprecated pkg_resources, replace with importlib qubes-desktop-linux-common#67 (QubesOS/qubes-desktop-linux-common@42def06)
• Wrap all JavaScript in an Immediately-Invoked Function Expression #19 (a1b31ca)
• SystemD dropins for minimal sys-net and sys-usb qubes-core-agent-linux#540 (QubesOS/qubes-core-agent-linux@f4b3d19)
• vmupdate: fix waiting for the other apt-get process qubes-core-admin-linux#175 (QubesOS/qubes-core-admin-linux@1d8ebf9)
• log stdout/err from updates check on Debian qubes-core-agent-linux#537 (QubesOS/qubes-core-agent-linux@e3202dc)
• Do not set timezone for VMs with anon-timezone feature qubes-core-admin#646 (QubesOS/qubes-core-admin@c76735f)
• Use the UUID for the machine ID qubes-core-admin#642 (QubesOS/qubes-core-admin@3efd0c3)
• Rip out qubes-rpc-multiplexer qubes-core-qrexec#141 (QubesOS/qubes-core-qrexec@b4164f1)
• Fix markup injection issues qubes-desktop-linux-manager#236 (QubesOS/qubes-desktop-linux-manager@4f3d7f1)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

• system_tests_whonix@hw7

  • startup: Failed (test died)
    # Test died: command 'qvm-run --nogui -u root sys-firewall qvm-sync...

• system_tests_gui_interactive@hw1

  • screenlocker_leaks: Failed (test died)
    # Test died: command 'qvm-run -p -u root work "dnf -y install mate-...

• system_tests_suspend@hw1

  • suspend: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_basic_vm_qrexec_gui@hw7

  • startup: Failed (test died)
    # Test died: command 'qvm-run --nogui -u root sys-firewall qvm-sync...

• system_tests_gui_tools@hw7

  • startup: Failed (test died)
    # Test died: command 'qvm-run --nogui -u root sys-firewall qvm-sync...

• system_tests_whonix

  • whonixcheck: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_gui_tools

  • desktop_linux_manager_policy_edit: unnamed test (unknown)
  • desktop_linux_manager_policy_edit: Failed (test died)
    # Test died: no candidate needle with tag(s) 'qubes-policy-editor-g...

• system_tests_suspend

  • suspend: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_gui_interactive

  • screenlocker_leaks: Failed (test died)
    # Test died: command 'qvm-run -p -u root work "dnf -y install mate-...

• system_tests_guivm_gui_interactive

  • update_guivm: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_backupdispvm

  • startup: wait_serial (wait serial expected + timed out)
    # wait_serial expected: "# "...

  • startup: wait_serial (wait serial expected)
    # wait_serial expected: qr/xE1Ra-\d+-/...

  • startup: Failed (test died + timed out)
    # Test died: command 'export TERM=dumb; stty cols 2048 rows 25' tim...

  • startup: wait_serial (wait serial expected)
    # wait_serial expected: "# "...

  • startup: wait_serial (wait serial expected)
    # wait_serial expected: qr/2E8vz-\d+-/...

• system_tests_kde_gui_interactive

  • kde_install: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_guivm_vnc_gui_interactive

  • update_guivm: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_basic_vm_qrexec_gui_btrfs

  • switch_pool: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_basic_vm_qrexec_gui_ext4

  • switch_pool: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_basic_vm_qrexec_gui_xfs

  • switch_pool: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

Failed tests

22 failures

• system_tests_whonix@hw7

  • startup: Failed (test died)
    # Test died: command 'qvm-run --nogui -u root sys-firewall qvm-sync...

• system_tests_gui_interactive@hw1

  • screenlocker_leaks: Failed (test died)
    # Test died: command 'qvm-run -p -u root work "dnf -y install mate-...

• system_tests_suspend@hw1

  • suspend: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_basic_vm_qrexec_gui@hw7

  • startup: Failed (test died)
    # Test died: command 'qvm-run --nogui -u root sys-firewall qvm-sync...

• system_tests_gui_tools@hw7

  • startup: Failed (test died)
    # Test died: command 'qvm-run --nogui -u root sys-firewall qvm-sync...

• system_tests_whonix

  • whonixcheck: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_gui_tools

  • desktop_linux_manager_policy_edit: unnamed test (unknown)
  • desktop_linux_manager_policy_edit: Failed (test died)
    # Test died: no candidate needle with tag(s) 'qubes-policy-editor-g...

• system_tests_suspend

  • suspend: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_gui_interactive

  • screenlocker_leaks: Failed (test died)
    # Test died: command 'qvm-run -p -u root work "dnf -y install mate-...

• system_tests_guivm_gui_interactive

  • update_guivm: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_backupdispvm

  • startup: wait_serial (wait serial expected + timed out)
    # wait_serial expected: "# "...

  • startup: wait_serial (wait serial expected)
    # wait_serial expected: qr/xE1Ra-\d+-/...

  • startup: Failed (test died + timed out)
    # Test died: command 'export TERM=dumb; stty cols 2048 rows 25' tim...

  • startup: wait_serial (wait serial expected)
    # wait_serial expected: "# "...

  • startup: wait_serial (wait serial expected)
    # wait_serial expected: qr/2E8vz-\d+-/...

• system_tests_kde_gui_interactive

  • kde_install: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_basic_vm_qrexec_gui_zfs

  • switch_pool: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_guivm_vnc_gui_interactive

  • update_guivm: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_basic_vm_qrexec_gui_btrfs

  • switch_pool: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_basic_vm_qrexec_gui_ext4

  • switch_pool: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

• system_tests_basic_vm_qrexec_gui_xfs

  • switch_pool: Failed (test died)
    # Test died: command 'qvm-run --no-gui -p -u root sys-net "command ...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

3 fixed

• system_tests_audio@hw1

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: too short audio, expected 10s, got 0.00013605442176...

• system_tests_extra

  • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

Unstable tests

• system_tests_update@hw1

  update2/Failed (1/5 times with errors)

  • job 121711 # Test died: command '(set -o pipefail; qubesctl --show-output stat...

• system_tests_update@hw7

  update2/Failed (1/5 times with errors)

  • job 121711 # Test died: command '(set -o pipefail; qubesctl --show-output stat...

• system_tests_update

  update2/Failed (1/5 times with errors)

  • job 121711 # Test died: command '(set -o pipefail; qubesctl --show-output stat...

[marmarek]

None of the upstream scripts in there have constructs like this, and documentation doesn't recommend it either. Does this PR fixes some specific issue?

[DemiMarie]

No, this PR does not fix any specific issue. There was either a comment or a past commit message mentioning that variable scope was unclear, and this does fix that. The purpose is to prevent future changes from shadowing or clobbering some critical variable and introducing a bug that would be extremely hard to track down.

[marmarek]

Plasma people said each script gets isolated scope, so this is not needed.

[DemiMarie]

That is great! Do you have a link to the discussion @marmarek?

[marmarek]

That is great! Do you have a link to the discussion @marmarek?

A question on the plasma matrix channel, I believe you are there too.

[marmarek]

I have no idea how to open this link (on a desktop client), but this is the message link: https://matrix.to/#/!gYaaEyvNWxTzXssOmq:kde.org/$4sVVYWLfQ1NcgslQJvy7wpnUw1gHA8sv90OgAy5Fyro?via=matrix.org&via=kde.org&via=im.kde.org