Introduce LocalVM to extract BaseVM being smaller class

[fepitre]

It prepares the work for RemoteVM.

[fepitre]

@marmarek can you run openQA on it please?

[marmarek]

Sure, I can, but I think you may want to first take care of unit tests, this one looks like a real issue:

  File "/home/user/builds/QubesOS/qubes-core-admin/qubes/vm/__init__.py", line 403, in load_extras
    for parent in self.xml.xpath("./devices"):
                  ^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'xpath'

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.53%. Comparing base (039b7d3) to head (e308e84).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   69.49%   69.53%   +0.03%     
==========================================
  Files          58       58              
  Lines       12465    12478      +13     
==========================================
+ Hits         8663     8676      +13     
  Misses       3802     3802              

Flag	Coverage Δ
unittests	69.53% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fepitre]

Sure, I can, but I think you may want to first take care of unit tests, this one looks like a real issue:

  File "/home/user/builds/QubesOS/qubes-core-admin/qubes/vm/__init__.py", line 403, in load_extras
    for parent in self.xml.xpath("./devices"):
                  ^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'xpath'

Fixed.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024120313-4.3&flavor=pull-requests

Test run included the following:

• WIP: Support for source domain in RPC service qubes-core-qrexec#182 (QubesOS/qubes-core-qrexec@2f0b1db)
• Introduce LocalVM to extract BaseVM being smaller class #637 (e308e84)

Installing updates failed, skipping the report!