Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Reset() method #8410

Merged

Conversation

Marinovsky
Copy link
Collaborator

@Marinovsky Marinovsky commented Nov 14, 2024

Description

Implement Reset() method in consolidators

Related Issue

Closes #8320

Motivation and Context

With this change users will be able to reset a consolidator

Requires Documentation Change

It might be useful to inform users about this new feature

How Has This Been Tested?

I created a base test class with a unit test that creates, updates and resets a consolidator asserting the it has been correctly been reset. This method depends on two other methods that can be overridden, so that the input type and assertion procedure can be adjusted

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Marinovsky Marinovsky changed the title Bug 8320 allow consolidator reset Implement Reset() method Nov 14, 2024
@Marinovsky Marinovsky changed the title Implement Reset() method Implement Reset() method Nov 14, 2024
Copy link
Collaborator

@jhonabreul jhonabreul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Leaving a few comments

Common/Data/Consolidators/DataConsolidator.cs Outdated Show resolved Hide resolved
Common/Data/Consolidators/DataConsolidator.cs Show resolved Hide resolved
Tests/Common/Data/BaseConsolidatorTests.cs Outdated Show resolved Hide resolved
Tests/Common/Data/BaseConsolidatorTests.cs Show resolved Hide resolved
Tests/Common/Data/VolumeRenkoConsolidatorTests.cs Outdated Show resolved Hide resolved
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@Martin-Molinero Martin-Molinero merged commit b99da54 into QuantConnect:master Nov 27, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Consolidator Reset
3 participants