-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Reset() method #8410
Merged
Martin-Molinero
merged 6 commits into
QuantConnect:master
from
Marinovsky:bug-8320-AllowConsolidatorReset
Nov 27, 2024
Merged
Implement Reset() method #8410
Martin-Molinero
merged 6 commits into
QuantConnect:master
from
Marinovsky:bug-8320-AllowConsolidatorReset
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marinovsky
changed the title
Bug 8320 allow consolidator reset
Implement Nov 14, 2024
Reset()
method
jhonabreul
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Leaving a few comments
Martin-Molinero
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
Reset()
method in consolidatorsRelated Issue
Closes #8320
Motivation and Context
With this change users will be able to reset a consolidator
Requires Documentation Change
It might be useful to inform users about this new feature
How Has This Been Tested?
I created a base test class with a unit test that creates, updates and resets a consolidator asserting the it has been correctly been reset. This method depends on two other methods that can be overridden, so that the input type and assertion procedure can be adjusted
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>