-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature issue#4581 Maximum Drawdown Recovery Time. #8280
Open
swisstackle
wants to merge
26
commits into
QuantConnect:master
Choose a base branch
from
swisstackle:feature-issue#4581-MaximumRecoveryTime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature issue#4581 Maximum Drawdown Recovery Time. #8280
swisstackle
wants to merge
26
commits into
QuantConnect:master
from
swisstackle:feature-issue#4581-MaximumRecoveryTime
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… end of the file for simpler diff.
…um drawdowns occur, the longest of all recoveries is reported.
swisstackle
changed the title
Feature issue#4581 maximum recovery time
Feature issue#4581 Maximum Drawdown Recovery Time.
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new statistic to measure the Maximum Drawdown Recovery Time.
Key changes:
MaxDrawdownRecoveryTime
function to calculate the longest recovery time from maximum drawdowns. In the case where there are multiple maximum drawdowns, the longest recovery time is returned.DrawdownPercentDrawdownDatesHighValue
function to consolidate theDrawdownPercent
function andMaxDrawdownRecoveryTime
function, to avoid duplicate code.DrawdownDrawdownDatesHighValueDTO
to avoid using tuples inDrawdownPercentDrawdownDatesHighValue
.Questions
DrawdownPercent
and the user could easily see where the maximum drawdown occured.Related Issue
Motivation and Context
Requires Documentation Change
Potentially
How Has This Been Tested?
Unit tests.
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>