Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Merge pending PRs #3

Merged
merged 4 commits into from
Jun 17, 2022
Merged

[Chore] Merge pending PRs #3

merged 4 commits into from
Jun 17, 2022

Conversation

Qu4tro
Copy link
Owner

@Qu4tro Qu4tro commented May 7, 2022

Hello everyone. I've decided to fork django-url-filter. After some clean-up, I think I'm almost ready to start merging some of the pending PRs that were in the original repository. @bernd-wechner your Django4 PR was already merged in #1 . Thank you for your contribution.

I've squashed each PR into a single commit (and hopefully I didn't botch anything).

These are the PRs merged in this Pull Request:

In regards to these:

I really want to merge them, but I feel like they warrant a couple of tests. If you're still interested, just write the tests and push a PR. I'll do my best to help in any questions you may have.

I might still take a couple of days to merge this PR - still need to finish some things, i.e tagged deployments to pypi on #1. This one will swiftly follow.

Let me take this chance, to thank you for your work. Your contribution matters!
Cheers.

@Qu4tro Qu4tro force-pushed the chore/merge-prs branch from b166228 to 8a9acce Compare May 7, 2022 03:56
@Qu4tro Qu4tro force-pushed the chore/merge-prs branch 2 times, most recently from e44f00b to ac1248b Compare May 8, 2022 18:36
@Qu4tro Qu4tro force-pushed the chore/merge-prs branch from ac1248b to 392da30 Compare May 9, 2022 01:32
@Qu4tro Qu4tro force-pushed the chore/cleanup branch 4 times, most recently from 7ed8f00 to b66303b Compare June 17, 2022 03:33
@Qu4tro Qu4tro force-pushed the chore/merge-prs branch 2 times, most recently from 6da06ef to 67d09d2 Compare June 17, 2022 03:47
Bastien Vallet and others added 4 commits June 17, 2022 03:50
@Qu4tro Qu4tro force-pushed the chore/merge-prs branch from 67d09d2 to 7e0763f Compare June 17, 2022 03:50
@Qu4tro Qu4tro merged commit 5eb64de into chore/cleanup Jun 17, 2022
@Qu4tro Qu4tro deleted the chore/merge-prs branch June 17, 2022 03:58
@bernd-wechner
Copy link

Thank you for taking the initiative of cleanup and merging. I wonder if @miki725 has abandoned the project.

If @miki725 has dropped the ball and doesn't intend to continue it might be worth not just forking by rebranding and I see you've done that and are now django-ufilter. To be clearer though I'd stick with pseudo conventions we see around the place, like djang-urlfilter2, or djang-urlfilterNG or djang-urlfilter+ whatever. Just a thought. I have been seriously low on time to contribute to anything in ages alas. But may pop up now and again in a useful context. I tend to be driven by a spot need and already in my requiremnets.txt refer to my own fork of django-urlfilter. But it would grand to see a half way maintained package on pypi.

@Qu4tro
Copy link
Owner Author

Qu4tro commented Jun 20, 2022

Hey! No problem at all. I assume so, as miki725#113 was left unanswered, yet his account has frequent and recent commits. He might be overstretched with work and so on, but it's clear he's not giving the package the attention it needs. Honestly, and if you're reading this @miki725, handing the project to something like https://github.com/jazzband, would be the best way forward.

Thanks for responding so promptly (although I missed the notification). Regarding the naming. I do think yours might have been a better idea, but I'll leave it as is for now. I've been reading the code every once in a while and I'm hoping I can start to make some meaningful changes when I have the time.

There are a few things that I want to resolve, like the lack of or operators. I can already feel the sweat of the DBAs reading this and hear C# developer to not reinvent OData, but I just might. I've forked this package, mainly to have your Django 4 PR as a PyPI package [1][2] , but I don't know where it might take me. Miki might come back to maintain the original, I might just keep doing stay-alive updates, to ensure it can be used, with warts and all or I might rewrite most of the code-base. I just don't know to be honest.

Anyway, I'm stretching too much as usual. I just want to finish, by thanking you again! You've been most helpful.

[1] https://pypi.org/project/django-ufilter/
[2] I don't like having GH repos as requirements, for several reasons, including lack of checksum support

@wonjaeL
Copy link

wonjaeL commented Aug 19, 2022

Thanks.

This helps me a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants