-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zachary's Karate Club #1280
Conversation
Pull Request Test Coverage Report for Build 11859929189Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Co-authored-by: Alexander Ivrii <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM thanks for adding this generator. I just have a few inline comments that will slightly improve the performance and/or simplify the code.
Co-authored-by: Matthew Treinish <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the updates.
* Karate club draft * Add Zachary's data * Consider weight for Karate Club * Add tests * Add karate_club_graph signature * Fix clippy * Update rustworkx-core/src/generators/karate_club.rs Co-authored-by: Alexander Ivrii <[email protected]> * Add labels and documentation * Test node labels * Add simple Rust docstring * Add release notes * Black changes * Update test to be independent * Apply suggestions from code review Co-authored-by: Matthew Treinish <[email protected]> * Format and u8 * Ignore ruff for that file * Use adjacency list * Add some documentation * Update tests/graph/test_karate.py --------- Co-authored-by: Alexander Ivrii <[email protected]> Co-authored-by: Matthew Treinish <[email protected]>
Adds the famous Zachary's karate club, a network that is used in many examples.
Makes #1277 easier and I assume it will be used in lots of example for community detection algorithms