Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid requirining new pyfunctions to be declared in lib.rs #1252

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

IvanIsCoding
Copy link
Collaborator

This is a very big refactor trying to tame lib.rs. Essentially we create a macro to avoid having to add m.add_wrapped(wrap_pyfunction!(your_new_function))?; every single time.

This will make it simpler for new contributors to add new methods, as now it is more likely they do not have to change lib.rs. If a new module is needed, the diff is similar but future contributions remain simple.

@IvanIsCoding IvanIsCoding requested a review from mtreinish July 14, 2024 21:01
@coveralls
Copy link

coveralls commented Jul 14, 2024

Pull Request Test Coverage Report for Build 11862646320

Details

  • 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 95.799%

Totals Coverage Status
Change from base Build 11860433299: -0.04%
Covered Lines: 17971
Relevant Lines: 18759

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants