Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to return edge indices from endpoints #1055

Merged
merged 8 commits into from
Jan 19, 2024

Conversation

eendebakpt
Copy link
Contributor

Fixes #978

@eendebakpt eendebakpt changed the title Add method to return edge indices from endpoints Add method to return edge incidences from endpoints Jan 16, 2024
@mtreinish mtreinish changed the title Add method to return edge incidences from endpoints Add method to return edge indices from endpoints Jan 18, 2024
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM, it does overlap with #1011 but that PR has been idle with open review comments for a couple months now and this addresses the feedback on that PR. I think the only thing still to do on this PR is fix the CI failure (it just needs to have black run as there is excess whitespace in the digraph tests) and also this could use a release note to document the new methods being added in this PR. The process for adding a release note is documented here: https://github.com/Qiskit/rustworkx/blob/main/CONTRIBUTING.md#release-notes

@mtreinish mtreinish added this to the 0.14.0 milestone Jan 18, 2024
@coveralls
Copy link

coveralls commented Jan 18, 2024

Pull Request Test Coverage Report for Build 7589534946

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 95.966%

Totals Coverage Status
Change from base Build 7578823264: 0.04%
Covered Lines: 16056
Relevant Lines: 16731

💛 - Coveralls

src/digraph.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
@mtreinish mtreinish added the automerge Queue a approved PR for merging label Jan 19, 2024
@mergify mergify bot merged commit e8e380b into Qiskit:main Jan 19, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a function to get edge indices from endpoints
3 participants