Skip to content

Commit

Permalink
Downgrade pp64le to tier 4 and skip tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mtreinish committed Oct 9, 2023
1 parent 714c1f2 commit a27e79f
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ jobs:
env:
CIBW_SKIP: cp36-* cp37-* cp39-* cp310-* cp311-* pp* *win32 *musl*
CIBW_ARCHS_LINUX: s390x
CIBW_TEST_SKIP: "*-*linux_s390x"
- uses: actions/upload-artifact@v3
with:
path: ./wheelhouse/*.whl
Expand Down Expand Up @@ -175,7 +174,6 @@ jobs:
env:
CIBW_SKIP: cp36-* cp37-* cp38-* cp312-* pp* *win32 *musl*
CIBW_ARCHS_LINUX: s390x
CIBW_TEST_SKIP: "*-*linux_s390x"
- uses: actions/upload-artifact@v3
with:
path: ./wheelhouse/*.whl
Expand Down
6 changes: 1 addition & 5 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ skip = "pp* cp36-* cp37-* *win32 *musllinux*i686"
test-requires = "networkx"
test-command = "python -m unittest discover {project}/tests/rustworkx_tests"
before-build = "pip install -U setuptools-rust"
test-skip = "cp38-*musllinux*"
test-skip = "cp38-*musllinux* *-*linux_s390x -*linux_ppc64le"

[tool.cibuildwheel.linux]
before-all = "yum install -y wget && {package}/tools/install_rust.sh"
Expand All @@ -27,9 +27,5 @@ before-all = "apk add apk add --no-cache curl gcc && curl https://sh.rustup.rs -
select = "*i686"
before-test = 'python -m pip install numpy --config-settings=setup-args="-Dallow-noblas=true"'

[[tool.cibuildwheel.overrides]]
select = "*ppc64le"
before-test = 'python -m pip install numpy --config-settings=setup-args="-Dallow-noblas=true"'

[tool.cibuildwheel.macos]
environment = "MACOSX_DEPLOYMENT_TARGET=10.9"
12 changes: 12 additions & 0 deletions releasenotes/notes/platform-updates-e9b296144e633c95.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,15 @@
features:
- |
Added support for musl Linux platforms on x86_64 and aarch64 at :ref:`tier-3`.
upgrade:
- |
Support for the Linux ppc64le pllatform has changed from tier 3 to tier 4
(as documented in :ref:`platform-suppport`). This is a result of no longer
being able to run tests during the pre-compiled wheel publishing jobs due
to constraints in the available CI infrastructure. There hopefully
shouldn't be any meaningful impact resulting from this change, but as there
are no longer tests being run to validate the binaries prior to publishing
them there are no longer guarantees that the wheels for ppc64le are fully
functional (although the likelihood they are is still high as it works on
other platforms). If any issues are encountered with ppc64le Linux please
open an issue.

0 comments on commit a27e79f

Please sign in to comment.