Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom mobile header & search box #582

Merged
merged 3 commits into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,7 @@ We use Sphinx's inheritance future for our Furo-based `qiskit` theme, which we s

We try to keep changes to a minimum because every divergence we make from base Furo increases our maintenance burden. Hence we prioritise only making changes that are important to the Qiskit brand. If the change would be generally useful to other users of Furo, we try to contribute upstream to the Furo project itself.

The `qiskit-ecosystem` theme then inherits the `qiskit` theme to make some tweaks:

1. Adding back `brand.html` to the left sidebar, but with some custom code.
2. Restoring Furo's `page.html` to restore the mobile header design.
3. `qiskit-ecosystem.css` fixing some logo sizing.
The `qiskit-ecosystem` theme then inherits the `qiskit` theme to make some tweaks, although we're removing the `qiskit` theme so the themes are converging.

### How to change HTML
Copy the HTML template from Furo and save it in the same file path. Then, at the top of the file, add this header:
Expand Down
22 changes: 0 additions & 22 deletions src/qiskit_sphinx_theme/assets/styles/_top-nav-bar.scss

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,15 @@
@import "left-sidebar";
@import "sphinx-extensions";
@import "tables";
@import "top-nav-bar";
@import "typography";

// Turn off scroll animation for anchor links: https://github.com/pradyunsg/furo/discussions/384
html {
scroll-behavior: auto;
}

// Disable dark mode for now, but probably re-enable in
// https://github.com/Qiskit/qiskit_sphinx_theme/issues/575.
.theme-toggle-container {
display: none;
}
218 changes: 0 additions & 218 deletions src/qiskit_sphinx_theme/ecosystem/page.html

This file was deleted.

12 changes: 0 additions & 12 deletions src/qiskit_sphinx_theme/ecosystem/sidebar/search.html

This file was deleted.

Loading
Loading