-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidied up breadcrumbs file #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
{% if theme_pytorch_project == 'tutorials' %} | ||
Tutorials | ||
{% else %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was a holdover from when the Tutorials were built using a separate process from the main package? Or it's possible it was just copied over from pytorch, because I don't remember seeing the theme_pytorch_project
variable anywhere in our codebases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the breadcrumbs! While I like that the button got removed, I prefer the spacing above and below the breadcrumb before the change. Not sure if this is related to solving the issue of long breadcrumb you mentioned in the description. It would be great if we can solve that issue while still maintain the spacing.
fixes #114
In this PR:
sphinx.ext.linkcode
so that source code links to GitHub #186 ) for further work on improving the source code linksbefore:
after: