Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coordinate map for Heron devices #12680

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

quantumjim
Copy link
Member

@quantumjim quantumjim commented Jun 28, 2024

Summary

Added a coordinate map, so that plot_gate_map can use the same layout the the IBM Quantum Platform, and not create one randomly.

Details and comments

Image below shows the output for from qiskit.visualization import plot_gate_map plot_gate_map(backend, figsize=(10,10)).
image

@quantumjim quantumjim requested review from nonhermitian and a team as code owners June 28, 2024 10:40
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

@mtreinish
Copy link
Member

I'm not a huge fan of continuing this pattern, we moved to using graphviz for graph visualization (see: #9031) so we didn't have to continue hard coding magic layouts in the visualization functions moving forward. It's not a really good solution because it assumes that all backends prefixed with ibm_ or fake_ and n qubits want to use the same layout. Prior to #9031 being implemented it was not great but better than using the algorithmic layout from rx.spring_layout() (which is garbage for more than a handful of nodes) but we're in a better state now. If the graphviz layout is deficient in some way it might be a better approach if we can come up with a better algorithmic layout for this.

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9711519430

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 89.753%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/gate_map.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit/visualization/gate_map.py 1 6.95%
crates/qasm2/src/lex.rs 4 92.11%
Totals Coverage Status
Change from base Build 9703107599: 0.01%
Covered Lines: 63808
Relevant Lines: 71093

💛 - Coveralls

@quantumjim
Copy link
Member Author

I agree that qubit_coordinates_map is not the best way to do things and should disappear in a future release. But while it is in the code, shouldn't it reflect public devices?

@coveralls
Copy link

coveralls commented Jul 5, 2024

Pull Request Test Coverage Report for Build 9805725895

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.006%) to 89.838%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/gate_map.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit/visualization/gate_map.py 1 6.95%
crates/qasm2/src/lex.rs 2 92.88%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 9794304676: 0.006%
Covered Lines: 65191
Relevant Lines: 72565

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 12, 2024

Pull Request Test Coverage Report for Build 9909366534

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.005%) to 89.874%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/gate_map.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
qiskit/visualization/gate_map.py 1 6.93%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.35%
crates/qasm2/src/lex.rs 5 92.11%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 9908506798: -0.005%
Covered Lines: 65743
Relevant Lines: 73150

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants