Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

feat(events): Fall fest 2023 #3530

Merged
merged 7 commits into from
Sep 5, 2023
Merged

feat(events): Fall fest 2023 #3530

merged 7 commits into from
Sep 5, 2023

Conversation

y4izus
Copy link
Contributor

@y4izus y4izus commented Sep 4, 2023

Changes

Fix #3517 and #3518

Implementation details

On the user story there are other 2 issues, but they will be done in the future

techtolentino and others added 2 commits August 29, 2023 09:13
* feat(fall-fest): add fall fest 2023 page and content file

* feat(fall-fest): add fall fest 2023 directory file, event img, and intro copy

* feat(fall-fest): remove directory and agenda for 2023

* Update pages/events/fall-fest.vue

Co-authored-by: Yaiza <[email protected]>

* Update pages/events/fall-fest.vue

Co-authored-by: Yaiza <[email protected]>

* Update pages/events/fall-fest.vue

Co-authored-by: Yaiza <[email protected]>

* feat(fall-fest): add description to content file

* feat(fall-fest): fix lint error

* feat(fall-fest): fix errors

---------

Co-authored-by: Yaiza <[email protected]>
Copy link
Contributor Author

@y4izus y4izus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, the card image on the header cut the text on mobile:

Captura de pantalla 2023-09-04 a las 14 43 43

constants/fallFest2023Content.ts Outdated Show resolved Hide resolved
constants/fallFest2023Content.ts Outdated Show resolved Hide resolved
@techtolentino
Copy link
Contributor

techtolentino commented Sep 5, 2023

One more thing, the card image on the header cut the text on mobile:

Captura de pantalla 2023-09-04 a las 14 43 43

Screenshot

Addressed the cut off text here, and improved the image alt description in this commit

Screen.Recording.2023-09-05.at.6.34.43.AM.mov

Copy link
Contributor

@techtolentino techtolentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by the team

@techtolentino techtolentino merged commit 7464d94 into main Sep 5, 2023
5 checks passed
@techtolentino techtolentino deleted the feat/fall-fest-2023 branch September 5, 2023 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive the current fall fest page
2 participants