Forward incoming error when decoding fails

[victor-villar]

Summary

Fixes: #35

When error decoding fails, forward incoming error.

Details and comments

[CLAassistant]

All committers have signed the CLA.

[y4izus]

Thank you Víctor! Could you review my suggestion?

[y4izus]

After reading this, I think we should avoid to have an except without possible exceptions. I would suggest to do:

Suggested change

	try:
	resp = exc.response.json()
	detail = resp.get("detail")
	# Default message
	msg = "Internal error."
	if isinstance(detail, str):
	msg = detail
	elif isinstance(detail, list):
	detail_input = detail[0]["input"]
	detail_msg = detail[0]["msg"]
	if detail_input and detail_msg:
	msg = f"Wrong input '{detail_input}'. {detail_msg}"
	except:
	# If something fails decoding the error
	# just show the incoming error
	msg = f"Internal error: {str(exc)}"
	# Default message
	msg = "Internal error."
	try:
	resp = exc.response.json()
	detail = resp.get("detail")
	if isinstance(detail, str):
	msg = detail
	elif isinstance(detail, list):
	detail_input = detail[0]["input"]
	detail_msg = detail[0]["msg"]
	if detail_input and detail_msg:
	msg = f"Wrong input '{detail_input}'. {detail_msg}"
	except (KeyError, TypeError, ValueError) as e:
	# If something fails decoding the error
	# just show the incoming error
	msg = f"Internal error: {str(e)}"

[victor-villar]

Actually it is not but I would put a plain Exception there as I do not want anything masking the real error. In any case I had to work on other urgent stuff and leave this as it is. I need to fix some tests, etc. 'll retake it when I have time!

[jesus-talavera-ibm]

LGTM!