Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for non-ISA operation inside operation flow blocks #1784

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Check for non-ISA operation inside operation flow blocks #1784

merged 7 commits into from
Jul 5, 2024

Conversation

yaelbh
Copy link
Collaborator

@yaelbh yaelbh commented Jul 2, 2024

Summary

Fixes a bug, where some of the ISA checks were skipped in dynamic circuits.

Details and comments

Fixes #1717.
I'll add a release note in a minute.

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9758068552

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.204%
Totals Coverage Status
Change from base Build 9749693234: 0.02%
Covered Lines: 6125
Relevant Lines: 7451
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9758366176

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.204%
Totals Coverage Status
Change from base Build 9749693234: 0.02%
Covered Lines: 6125
Relevant Lines: 7451
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9762406112

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.204%
Totals Coverage Status
Change from base Build 9749693234: 0.02%
Covered Lines: 6125
Relevant Lines: 7451
💛 - Coveralls

t-imamichi
t-imamichi approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9809814340

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.197%
Totals Coverage Status
Change from base Build 9785040174: 0.02%
Covered Lines: 6127
Relevant Lines: 7454
💛 - Coveralls

@kt474 kt474 merged commit 04d05ce into Qiskit:main Jul 5, 2024
18 checks passed
@yaelbh yaelbh mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamFerracin SamFerracin SamFerracin left review comments

@t-imamichi t-imamichi t-imamichi approved these changes

@kt474 kt474 kt474 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ISA check skips instructions inside conditional blocks
5 participants
@yaelbh @coveralls @kt474 @t-imamichi @SamFerracin