Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend required param when using cloud channel #1739

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Backend required param when using cloud channel #1739

merged 4 commits into from
Jun 13, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jun 10, 2024

Summary

Details and comments

Fixes #1416
Follow up to #1425

@coveralls
Copy link

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9454638344

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 82.321%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/base_primitive.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/session.py 1 83.72%
qiskit_ibm_runtime/base_primitive.py 2 93.23%
Totals Coverage Status
Change from base Build 9452478202: -0.09%
Covered Lines: 6058
Relevant Lines: 7359
💛 - Coveralls

@kt474 kt474 marked this pull request as ready for review June 10, 2024 20:16
@coveralls
Copy link

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9500331759

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 82.299%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/base_primitive.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/session.py 1 83.72%
qiskit_ibm_runtime/base_primitive.py 2 93.23%
Totals Coverage Status
Change from base Build 9488511809: -0.09%
Covered Lines: 6035
Relevant Lines: 7333
💛 - Coveralls

@kt474 kt474 added the Changelog: Removal Include in the Removed section of the changelog label Jun 13, 2024
@coveralls
Copy link

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9500718157

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 82.299%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/base_primitive.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/session.py 1 83.72%
qiskit_ibm_runtime/base_primitive.py 2 93.23%
Totals Coverage Status
Change from base Build 9488511809: -0.09%
Covered Lines: 6035
Relevant Lines: 7333
💛 - Coveralls

@kt474 kt474 merged commit 5ec534d into Qiskit:main Jun 13, 2024
20 checks passed
@kt474 kt474 deleted the require-cloud-backend-2 branch June 13, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptristan3 ptristan3 ptristan3 approved these changes

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make backend required for cloud channel
3 participants
@kt474 @coveralls @ptristan3