-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mode parameter #1584
Merged
Merged
Add mode parameter #1584
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
8604665
add mode param and deprecate warning to session.
ptristan3 03a72ba
replaced session by mode
ptristan3 689892f
fix tests
ptristan3 8424587
Merge branch 'main' into rename-session-parameter
ptristan3 f8c927c
fix tests
ptristan3 eeead9a
update method
ptristan3 8d045c4
update mode value
ptristan3 9a66d78
Merge branch 'main' into rename-session-parameter
ptristan3 617f9fe
replaced backend and session params with mode
ptristan3 75aa46a
Added mode param. Deprecated backend and session.
ptristan3 80f34f3
Updated V2 tests using mode param.
ptristan3 82b720a
Updated _backend
ptristan3 d0a383d
updated tests
ptristan3 6361a58
improve docstrings
ptristan3 357d5ec
style fixes
ptristan3 e8a242a
back backend param
ptristan3 235eb9d
pylint fixes
ptristan3 f9f3f6e
mypy fixes
ptristan3 81c59e2
updated the backend for cm session
ptristan3 a02c8ff
ignore type
ptristan3 6343fa3
added release notes
ptristan3 a61fd69
update deprecation message
ptristan3 ef2bf0b
Apply suggestions from code review
ptristan3 23e0687
improve docstrings
ptristan3 124092d
revert V1 changes
ptristan3 72348ea
Merge branch 'main' into rename-session-parameter
ptristan3 3bb5553
Update from PR comments
ptristan3 81907bd
Merge branch 'main' into rename-session-parameter
ptristan3 7edd896
back to backend arg
ptristan3 fb8dbf8
update release notes
ptristan3 88b1fed
Update qiskit_ibm_runtime/sampler.py
ptristan3 c6360da
Update qiskit_ibm_runtime/estimator.py
ptristan3 0a8eedc
Update qiskit_ibm_runtime/sampler.py
ptristan3 85865a8
Update qiskit_ibm_runtime/base_primitive.py
ptristan3 9110b8d
Update qiskit_ibm_runtime/base_primitive.py
ptristan3 be879af
updated from PR comments
ptristan3 d9ba2b2
Merge branch 'main' into rename-session-parameter
ptristan3 8727d69
updated from PR comments
ptristan3 6085b31
update docstring
ptristan3 b0614e7
Merge branch 'main' into rename-session-parameter
ptristan3 ed67df8
Update qiskit_ibm_runtime/estimator.py
ptristan3 9db4ba6
Update qiskit_ibm_runtime/sampler.py
ptristan3 e4770f9
Update qiskit_ibm_runtime/base_primitive.py
ptristan3 c0bf453
Merge branch 'main' into rename-session-parameter
ptristan3 83ce49c
linter fixes
ptristan3 4ee1b05
split mode param tests
ptristan3 10a0bed
Merge branch 'main' into rename-session-parameter
ptristan3 a445b21
Merge branch 'main' into rename-session-parameter
ptristan3 9f8aabe
Merge branch 'main' into rename-session-parameter
ptristan3 317b795
merged manually
ptristan3 2db0329
add missing import
ptristan3 389d21c
Merge branch 'main' into rename-session-parameter
ptristan3 b1baf16
Merge branch 'main' into rename-session-parameter
ptristan3 c1d4efc
Merge branch 'main' into rename-session-parameter
kt474 a190b6d
Merge branch 'main' into rename-session-parameter
kt474 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
`backend` argument in `Sampler <https://docs.quantum.ibm.com/run/primitives-get-started#3-initialize-the-qiskit-runtime-sampler>`__ and `Estimator <https://docs.quantum.ibm.com/run/primitives-get-started#3-initialize-qiskit-runtime-estimator>`__ has been deprecated . Please use the new `mode` argument instead. | ||
`session` argument in `Sampler <https://docs.quantum.ibm.com/run/primitives-get-started#3-initialize-the-qiskit-runtime-sampler>`__ and `Estimator <https://docs.quantum.ibm.com/run/primitives-get-started#3-initialize-qiskit-runtime-estimator>`__ has been deprecated . Please use the new `mode` argument instead. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Related to the execution modes, Sampler and Estimator now include a `mode` argument. The `mode` param | ||
can be a Backend, Session, Batch, or None. Due to this, the backend name has been deprecated, and will | ||
no longer be supported as a valid execution mode. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't just remove the
session
attribute without deprecating it first.