Add V2 primitive Q-Ctrl tests #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8565471759Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jyu00
reviewed
Apr 4, 2024
test/qctrl/test_qctrl.py
Outdated
| def setUp(self) -> None: | ||
| super().setUp() | ||
| self.bell = bell() | ||
| self.backend = "alt_canberra" |
There was a problem hiding this comment.
We shouldn't hard code backend name
test/qctrl/test_qctrl.py
Outdated
| @run_integration_test | ||
| def test_sampler_v2_qctrl(self, service): | ||
| """Test qctrl bell state with samplerV2""" | ||
| shots = 1000 |
There was a problem hiding this comment.
Let's save some QPU time if we are not verifying result data
Suggested change
| shots = 1000 | |
| shots = 1 |
jyu00
reviewed
Apr 4, 2024
test/qctrl/test_qctrl.py
Outdated
Comment on lines
54
to
57
| bell_circuit = QuantumCircuit(2) | ||
| bell_circuit.h(0) | ||
| bell_circuit.cx(0, 1) | ||
| bell_circuit.measure_all() |
There was a problem hiding this comment.
nit - why create your own bell circuit when there is a self.bell?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ready for initial review - wasn't completely sure how detailed the tests should be, my understanding is that we're just testing "does it run"/happy path.
Details and comments
Fixes #1499