Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from_id() #1311

Merged
merged 14 commits into from
Apr 9, 2024
Merged

Update from_id() #1311

merged 14 commits into from
Apr 9, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jan 10, 2024 •
edited
Loading

Summary

Details and comments

Fixes #1309
Fixes #1369

@coveralls
Copy link

coveralls commented Jan 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8607333428

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 83.539%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/api/rest/runtime_session.py 0 1 0.0%
qiskit_ibm_runtime/session.py 8 11 72.73%
Totals Coverage Status
Change from base Build 8603635660: 0.05%
Covered Lines: 6232
Relevant Lines: 7460
💛 - Coveralls

@kt474 kt474 mentioned this pull request Jan 22, 2024
Closed
@kt474 kt474 requested a review from jyu00 January 22, 2024 05:32
jyu00
jyu00 requested changes Jan 23, 2024
View reviewed changes
qiskit_ibm_runtime/session.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/session.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/session.py Outdated Show resolved Hide resolved
@kt474 kt474 added the Changelog: Deprecation Include in Deprecated section of changelog label Feb 27, 2024
@kt474 kt474 mentioned this pull request Apr 3, 2024
Closed
jyu00
jyu00 reviewed Apr 4, 2024
View reviewed changes
qiskit_ibm_runtime/session.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/session.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/session.py Outdated Show resolved Hide resolved
jyu00
jyu00 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on docstring but otherwise looks good.

qiskit_ibm_runtime/session.py Show resolved Hide resolved
qiskit_ibm_runtime/session.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/session.py Outdated Show resolved Hide resolved
@kt474 kt474 merged commit 0baac08 into Qiskit:main Apr 9, 2024
20 checks passed
@kt474 kt474 deleted the session-from-id-backend branch April 9, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriedem mriedem mriedem left review comments

@jyu00 jyu00 jyu00 approved these changes

Assignees
No one assigned
Labels
Changelog: Deprecation Include in Deprecated section of changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify execution mode in from_id() backend data missing when using Session.from_id()
4 participants
@kt474 @coveralls @mriedem @jyu00