Cleaned code involving noise_amplifier options #1184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, since currently only one option is supported
Pull Request Test Coverage Report for Build 6704017400
💛 - Coveralls |
kt474
reviewed
Oct 31, 2023
| @@ -53,7 +49,7 @@ class ResilienceOptions: | |||
| Default: ``None``, and ``LinearExtrapolator`` if resilience level is 2. | |||
| """ | |||
|
|
|||
| noise_amplifier: NoiseAmplifierType = None | |||
| noise_amplifier: NoiseAmplifierType = "LocalFoldingAmplifier" | |||
There was a problem hiding this comment.
We can't merge this until there is an update on the server side right? Because this would add noise_amplifier to every job, including those without resilience_level 2
There was a problem hiding this comment.
As far as I understand, this will have no effect on other resilience levels, because ZNE won't be run. @jyu00 - any comment on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed the code involving noise_amplifier documentation and checking, since currently only one option is supported.
Details and comments
See comment in #1093.