Merge pull request #45 from Qiskit/fix-40-update

Fix related to issue 40: a package must be only updated when the user accepts the modal dialog
Qiskit · Oct 25, 2018 · a7c45b9 · a7c45b9
2 parents 7c5aac2 + 7b91b28
commit a7c45b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### 🎉 Added
 
 ### 🐛 Fixed
+- Changing update packages modal behavior: they must be only updated if the user clicks OK explicitly ([#45](https://github.com/Qiskit/qiskit-vscode/pull/45) by [@cbjuan](https://github.com/cbjuan))
 
 ### ✏️ Changed
 

diff --git a/client/src/packages/packageManager.ts b/client/src/packages/packageManager.ts
@@ -126,8 +126,8 @@ export class PackageManager {
             QLogger.verbose(`Clicked on Dismiss!`, this);
             return false;
         } else {
-            QLogger.verbose(`Clicked on other element! Updating anyway...`, this);
-            return true;
+            QLogger.verbose(`Clicked on another element! Cancelling update`, this);
+            return false;
         }
     }