-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate save_expval #2216
Merged
Merged
Truncate save_expval #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doichanj
added
the
stable-backport-potential
The issue or PR might be minimal and/or import enough to backport to stable
label
Sep 11, 2024
Merged
revert to 0.15.0
hhorii
approved these changes
Sep 12, 2024
doichanj
added a commit
to doichanj/qiskit-aer
that referenced
this pull request
Sep 12, 2024
* truncate save_expval * fix truncation * fix truncation * add num_original_qubits to aer_circuit to get num_qubits without ancilla qubits * Fix adding qubitset * add test case, release note and fix docs * fix doc * fix doc * fix doc * fix doc * fix doc * fix doc * fix doc * fix doc * change truncation strategy * format * remove print * no truncation when circuit is empty * Update VERSION.txt revert to 0.15.0 --------- Co-authored-by: Hiroshi Horii <[email protected]>
doichanj
added a commit
that referenced
this pull request
Sep 13, 2024
* Add `open_pulse` entry to `AerBackendConfiguration` (#2214) * add open_pulse entry to AerBackendConfiguration * add test * Fix tests Aer 0.15 in the latest environments (#2223) * qiskit 1.0.0rc1 -> 1.3.0b1 * test * test * fix tutorial * add release note * change version number * Revert NoiseModel.from_dict (#2222) * Truncate save_expval (#2216) * truncate save_expval * fix truncation * fix truncation * add num_original_qubits to aer_circuit to get num_qubits without ancilla qubits * Fix adding qubitset * add test case, release note and fix docs * fix doc * fix doc * fix doc * fix doc * fix doc * fix doc * fix doc * fix doc * change truncation strategy * format * remove print * no truncation when circuit is empty * Update VERSION.txt revert to 0.15.0 --------- Co-authored-by: Hiroshi Horii <[email protected]> --------- Co-authored-by: Takashi Imamichi <[email protected]> Co-authored-by: Hiroshi Horii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
stable-backport-potential
The issue or PR might be minimal and/or import enough to backport to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR truncates save_expval instruction when using
EstimatorV2.from_backend()
for small circuits.Details and comments
Ancilla qubits are added when transpiling small circuits with non-simulator backends that increases number of qubits to backends' qubits, and causes max memory error.
This PR truncates qubits of circuits with save_expval and restore Pauli string when saving expval to the results.