Fix legacy accesses of CircuitInstruction
#2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Terra's `CircuitInstruction` like a tuple is a legacy access pattern. The pattern of using named access attributes was introduced about two years ago, and the legacy format is about to be deprecated. This fixes up the last couple of uses.
garrison
added a commit
to garrison/qiskit-aer
that referenced
this pull request
Jul 10, 2024
This is a follow-up to Qiskit#2179, with similar fixes in two tests.
doichanj
pushed a commit
that referenced
this pull request
Jul 12, 2024
This is a follow-up to #2179, with similar fixes in two tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using Terra's
CircuitInstructionlike a tuple is a legacy access pattern. The pattern of using named access attributes was introduced about two years ago, and the legacy format is about to be deprecated. This fixes up the last couple of uses.Details and comments
Terra 1.2 will likely deprecate this.