Fix from backend of V2 primitives to use existing AerSimulator #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doichanj
added
Changelog: Bugfix
hhorii
reviewed
Jun 15, 2024
| @@ -130,6 +133,7 @@ def _run_pub(self, pub: EstimatorPub) -> PubResult: | |||
| result = self._backend.run( | |||
| circuit, parameter_binds=[parameter_binds], **self.options.run_options | |||
| ).result() | |||
| print(result) | |||
There was a problem hiding this comment.
I forgot to delete this one
hhorii
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
EstimatorV2.from_backendandSamplerV2.from_backendto use pre-defined AerSimulator for simulationDetails and comments
With this fix, user can define specific simulator object with backend options instead of passing options for V2 primitives.
for example, following script can use AerSimulator with statevector simulation and with noise model
This PR fixes
from_backendthat initialized backend object by callingAerSimulator.from_backendbut when input backend is AerSimulator just copy it.