Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined behaviors #2130

Merged
merged 7 commits into from
Jul 9, 2024
Merged

fix undefined behaviors #2130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
72460be
fix undefined behaviours
enum-class May 9, 2024
e6302b0
Run clang format 15 instead of 18
enum-class May 9, 2024
f388256
Merge branch 'main' into ub_fix
doichanj May 21, 2024
c2811e6
OpenMP for statement must have signed integral type
enum-class May 22, 2024
966d5bc
Merge branch 'Qiskit:main' into ub_fix
enum-class May 24, 2024
f2ed2b9
Merge branch 'main' into ub_fix
doichanj Jul 8, 2024
510c28f
Merge branch 'main' into ub_fix
doichanj Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/framework/operations.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1775,7 +1775,7 @@ Op input_to_op_bfunc(const inputdata_t &input) {
auto it = comp_table.find(relation);
if (it == comp_table.end()) {
std::stringstream msg;
msg << "Invalid bfunc relation string :\"" << it->first << "\"."
msg << "Invalid bfunc relation string :\"" << relation << "\"."
<< std::endl;
throw std::invalid_argument(msg.str());
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/simulators/density_matrix/densitymatrix_executor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1323,7 +1323,7 @@ Executor<densmat_t>::sample_measure(const reg_t &qubits, uint_t shots,
#endif

// Convert to SampleVector format
int_t npar = Base::parallel_state_update_;
uint_t npar = Base::parallel_state_update_;
if (npar > local_samples.size())
npar = local_samples.size();
std::vector<SampleVector> all_samples(shots, SampleVector(qubits.size()));
Expand Down
2 changes: 1 addition & 1 deletion src/simulators/density_matrix/densitymatrix_state.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,7 +1003,7 @@ std::vector<SampleVector> State<densmat_t>::sample_measure(const reg_t &qubits,
allbit_samples = BaseState::qreg_.sample_measure(rnds);

// Convert to bit format
int_t npar = BaseState::threads_;
uint_t npar = BaseState::threads_;
if (npar > shots)
npar = shots;
std::vector<SampleVector> all_samples(shots, SampleVector(qubits.size()));
Expand Down
2 changes: 1 addition & 1 deletion src/simulators/state.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ class Base {

// Maximum threads which may be used by the backend for OpenMP multithreading
// Default value is single-threaded unless overridden
int threads_ = 1;
uint_t threads_ = 1;

// Set a global phase exp(1j * theta) for the state
bool has_global_phase_ = false;
Expand Down
2 changes: 1 addition & 1 deletion src/simulators/statevector/statevector_executor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,7 +1241,7 @@ Executor<state_t>::sample_measure(const reg_t &qubits, uint_t shots,
#endif

// Convert to SampleVector format
int_t npar = Base::parallel_state_update_;
uint_t npar = Base::parallel_state_update_;
if (npar > local_samples.size())
npar = local_samples.size();
std::vector<SampleVector> all_samples(shots, SampleVector(qubits.size()));
Expand Down
Loading