-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump qiskit-ibm-runtime version and use mode=batch
#623
Conversation
This is necessary to prevent a `DeprecationWarning` under qiskit-ibm-runtime 0.24, which is currently visible in the [first](https://qiskit-extensions.github.io/circuit-knitting-toolbox/circuit_cutting/tutorials/01_gate_cutting_to_reduce_circuit_width.html) and third tutorials and is due to the merging of Qiskit/qiskit-ibm-runtime#1584. qiskit-ibm-runtime 0.24 depends on qiskit>=1.1, so I had to bump the qiskit version as well. Technically, this version bump is only required by the notebooks, not the actual CKT library, but the "minimum version tests" aren't equipped to deal with situations where the notebooks have a different minimum version than the library.
Pull Request Test Coverage Report for Build 9475947048Details
💛 - Coveralls |
This looks great but I am wondering if it may be helpful to refer to the exact cell in tutorial 1 where this |
Actually never mind, I take that back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks!
This is necessary to prevent a `DeprecationWarning` under qiskit-ibm-runtime 0.24, which is currently visible in the [first](https://qiskit-extensions.github.io/circuit-knitting-toolbox/circuit_cutting/tutorials/01_gate_cutting_to_reduce_circuit_width.html) and third tutorials and is due to the merging of Qiskit/qiskit-ibm-runtime#1584. This means that the notebooks now depend on qiskit-ibm-runtime 0.24, which depends on qiskit>=1.1. The "minimum version tests" aren't equipped to deal with situations where the notebooks have a different minimum version than the library. For this reason I've disabled the "minimum version tests" on the current stable branch going forward for the notebooks only. I don't want to bump the minimum version of any library on the stable branch, but I _do_ want to update our code examples to the latest version of qiskit-ibm-runtime.
…628) This is necessary to prevent a `DeprecationWarning` under qiskit-ibm-runtime 0.24, which is currently visible in the [first](https://qiskit-extensions.github.io/circuit-knitting-toolbox/circuit_cutting/tutorials/01_gate_cutting_to_reduce_circuit_width.html) and third tutorials and is due to the merging of Qiskit/qiskit-ibm-runtime#1584. This means that the notebooks now depend on qiskit-ibm-runtime 0.24, which depends on qiskit>=1.1. The "minimum version tests" aren't equipped to deal with situations where the notebooks have a different minimum version than the library. For this reason I've disabled the "minimum version tests" on the current stable branch going forward for the notebooks only. I don't want to bump the minimum version of any library on the stable branch, but I _do_ want to update our code examples to the latest version of qiskit-ibm-runtime.
This is necessary to prevent a
DeprecationWarning
under qiskit-ibm-runtime 0.24, which is currently visible in the first and third tutorials. The warning is a result of the merging of Qiskit/qiskit-ibm-runtime#1584.qiskit-ibm-runtime 0.24 depends on qiskit>=1.1, so I had to bump the qiskit version as well.
Technically, this version bump is only required by the notebooks, not the actual CKT library, but the "minimum version tests" aren't equipped to deal with situations where the notebooks have a different minimum version than the CKT library.