Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump qiskit-ibm-runtime version and use mode=batch #623

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

garrison
Copy link
Member

@garrison garrison commented Jun 12, 2024

This is necessary to prevent a DeprecationWarning under qiskit-ibm-runtime 0.24, which is currently visible in the first and third tutorials. The warning is a result of the merging of Qiskit/qiskit-ibm-runtime#1584.

qiskit-ibm-runtime 0.24 depends on qiskit>=1.1, so I had to bump the qiskit version as well.

Technically, this version bump is only required by the notebooks, not the actual CKT library, but the "minimum version tests" aren't equipped to deal with situations where the notebooks have a different minimum version than the CKT library.

This is necessary to prevent a `DeprecationWarning` under
qiskit-ibm-runtime 0.24, which is currently visible in the
[first](https://qiskit-extensions.github.io/circuit-knitting-toolbox/circuit_cutting/tutorials/01_gate_cutting_to_reduce_circuit_width.html)
and third tutorials and is due to the merging of
Qiskit/qiskit-ibm-runtime#1584.

qiskit-ibm-runtime 0.24 depends on qiskit>=1.1, so I had to
bump the qiskit version as well.

Technically, this version bump is only required by the notebooks,
not the actual CKT library, but the "minimum version tests" aren't
equipped to deal with situations where the notebooks have a
different minimum version than the library.
@garrison garrison added the dependencies Pull requests that update a dependency file label Jun 12, 2024
@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9475947048

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9352144331: 0.0%
Covered Lines: 2411
Relevant Lines: 2411

💛 - Coveralls

@garrison garrison marked this pull request as ready for review June 13, 2024 01:00
@garrison garrison requested a review from ibrahim-shehzad June 14, 2024 09:47
@ibrahim-shehzad
Copy link
Collaborator

ibrahim-shehzad commented Jun 17, 2024

This looks great but I am wondering if it may be helpful to refer to the exact cell in tutorial 1 where this DeprecationWarning appears.

@ibrahim-shehzad
Copy link
Collaborator

This looks great but I am wondering if it may be helpful to refer to the exact cell in tutorial 1 where this DeprecationWarning appears.

Actually never mind, I take that back.

Copy link
Collaborator

@ibrahim-shehzad ibrahim-shehzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@garrison garrison merged commit 6560929 into main Jun 17, 2024
11 checks passed
@garrison garrison deleted the batch-mode branch June 17, 2024 20:52
garrison added a commit that referenced this pull request Jun 17, 2024
This is necessary to prevent a `DeprecationWarning` under
qiskit-ibm-runtime 0.24, which is currently visible in the
[first](https://qiskit-extensions.github.io/circuit-knitting-toolbox/circuit_cutting/tutorials/01_gate_cutting_to_reduce_circuit_width.html)
and third tutorials and is due to the merging of
Qiskit/qiskit-ibm-runtime#1584.

This means that the notebooks now depend on
qiskit-ibm-runtime 0.24, which depends on qiskit>=1.1.

The "minimum version tests" aren't equipped to deal with situations
where the notebooks have a different minimum version than the
library.  For this reason I've disabled the "minimum version tests"
on the current stable branch going forward for the notebooks only.
I don't want to bump the minimum version of any library on the
stable branch, but I _do_ want to update our code examples
to the latest version of qiskit-ibm-runtime.
garrison added a commit that referenced this pull request Jul 8, 2024
…628)

This is necessary to prevent a `DeprecationWarning` under
qiskit-ibm-runtime 0.24, which is currently visible in the
[first](https://qiskit-extensions.github.io/circuit-knitting-toolbox/circuit_cutting/tutorials/01_gate_cutting_to_reduce_circuit_width.html)
and third tutorials and is due to the merging of
Qiskit/qiskit-ibm-runtime#1584.

This means that the notebooks now depend on
qiskit-ibm-runtime 0.24, which depends on qiskit>=1.1.

The "minimum version tests" aren't equipped to deal with situations
where the notebooks have a different minimum version than the
library.  For this reason I've disabled the "minimum version tests"
on the current stable branch going forward for the notebooks only.
I don't want to bump the minimum version of any library on the
stable branch, but I _do_ want to update our code examples
to the latest version of qiskit-ibm-runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants