-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to securely manage token #2322
Merged
Merged
Changes from 12 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
cab2eea
test twisty
abbycross f92740f
add info on env variable
abbycross 8cf4f0f
add to functions intro page
abbycross 880a541
squeaky
abbycross 8e7b1bd
add separate section
abbycross 929a1a0
tweak
abbycross 6004777
restore IBM Cloud note
abbycross ca16e69
Update setup-channel.mdx
abbycross 08377eb
Update docs/guides/setup-channel.mdx
abbycross 5747749
Add tabs w/Runtime option
abbycross eb1b3a1
Apply suggestions from code review
abbycross 602289c
Update docs/guides/functions.ipynb
abbycross 6f5ed59
Update setup-channel.mdx
abbycross 04285f9
rework page
abbycross 05ec983
rmv ref to removed section
abbycross 2973262
tweaks
abbycross a150476
rmv extra comments
abbycross d1f89a0
clarify default
abbycross 215ab29
updates to the Platform section of the page
abbycross 2b88216
redundant
abbycross ff129c2
bold
abbycross 8b20e08
instructions for untrusted machine
abbycross d2451be
input from Vignesh
abbycross 4aa4333
tweaks to iqp section
abbycross 185939a
no need to italicize twice in a row
abbycross 8e334db
first pass at REST API section
abbycross 8d26470
test out subsection for REST API
abbycross c800067
Update docs/guides/setup-channel.mdx
abbycross b8df8c2
Update docs/guides/setup-channel.mdx
abbycross 1f3d40d
move adm higher, rmv "or random", use original lang
abbycross 0e18cd3
rmv "in plain text"
abbycross 2bb59bf
add save_account() API link
abbycross f20da5a
copy paste code from account pg
abbycross b311aa2
fix indent
abbycross 84de35b
rmv overwrite=True
abbycross e7acc27
separate into 2 blocks
abbycross 8aeac62
tweaks
abbycross acc2bbd
updating wording on Functions pg
abbycross 54a6c47
tox
abbycross 7925905
Merge branch 'main' into ajc/update-install-instructions
abbycross c84195d
start fresh w serverless-manage-resources
abbycross d201682
rmv placeholder API text
abbycross 9f34a79
comment in qunasys code
abbycross d3d602e
Update serverless-manage-resources.ipynb
abbycross 1e59e09
add comments, remove placeholder text for api code
abbycross 8374f06
add catalog back in
abbycross 97b4f1d
more fix
abbycross 5f31633
underscore
abbycross beb9434
tox
abbycross cb6b6fc
Apply suggestions from code review
abbycross b003b40
Update docs/guides/setup-channel.mdx
abbycross e0a952d
Update docs/guides/setup-channel.mdx
abbycross dbf79a9
Merge branch 'main' into ajc/update-install-instructions
abbycross 6f5da2e
format a la iqp section
abbycross 0be84fc
bring warning higher up in section
abbycross 89ad0c0
break up line for readability
abbycross 8c89b3e
Python to `python`
abbycross ee626fe
update untrusted language
abbycross 57dbf4f
clarify refresh token language
abbycross a055c25
expire rather than rotate
abbycross c5a9851
what to do if you accidentally share token
abbycross dc974c2
tox
abbycross fe3ad1f
Update docs/guides/setup-channel.mdx
abbycross 9eec6b9
Update docs/guides/setup-channel.mdx
abbycross cb4f46f
Update docs/guides/setup-channel.mdx
abbycross 58a0205
pythonic
abbycross 065dd39
Merge branch 'ajc/update-install-instructions' of https://github.com/…
abbycross 9a14488
fix up token name
abbycross File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this paragraph misleading. It seems to say using an env variable is more secure than using
save_account()
, which is not true because (1) both save in plain text and (2) the instruction later usessave_account()
anyway.I believe what we are trying to tell people to avoid using their API token in their notebooks ever. Hence I'd suggest:
(token="<YOUR_IQP_API_TOKEN>")
to just()
, perhaps with a note/link to the setup page if they haven't done so.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, especially point 3. will be great to make code examples more easily runnable for testing