Qrispqiro quark #136
Qrispqiro quark #136
Conversation
Nik-SteinFraunh
requested review from
philross,
drelu and
Marvmann
as code owners
src/modules/Core.py
Outdated
| given option. | ||
|
|
||
| :param option: The chosen option | ||
| :type option: str |
There was a problem hiding this comment.
Correct. I will make sure the style matches the rest of the code after the changes in #142. Same for syncing it with the new structure introduced in Release 2.1.1.
| depending_submodules = True | ||
| if not depending_submodules: | ||
| available_submodules = module.get_available_submodule_options() | ||
| more_module_config = {} |
There was a problem hiding this comment.
I think we need a comment explaining module_config, more_module_config and full_module_config.
.settings/module_db.json
Outdated
| @@ -3568,4 +3568,4 @@ | |||
| "requirements": [] | |||
| } | |||
| ] | |||
| } | |||
There was a problem hiding this comment.
@Marvmann Is "qrisp" now a new dependency? If yes the module_db should be updated.
There was a problem hiding this comment.
yes, and module_db has been adjusted!
|
|
||
| full_application_config = ConfigManager._query_for_config( |
There was a problem hiding this comment.
@Marvmann I think this should be described in Read The Docs under the "Developer" section.
There was a problem hiding this comment.
Ok, I will provide a paragraph.
| full_application_config = ConfigManager._query_for_config( | ||
| application_config, f"(Option for {application_answer['application']})") | ||
| depending_submodules = False | ||
| for parameter in application_config: |
There was a problem hiding this comment.
I think some comments are needed here to improve readability.
There was a problem hiding this comment.
Yeah, similar to the module_config. It is the same logic.
Integrate suggestions
Marvmann
dismissed
philross’s stale review
Requested changes were implemented.
Integration of Qrisp QIRO for MIS.
Includes:
mapping
solver
device