-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combine new UPF-v3 schema with ltalirz/upf-schema (v2) and add ghpage #11
base: master
Are you sure you want to change the base?
Conversation
That's great work @unkcpz , I'm all for it and will happily archive my repository after this is done. I think creating similar pages for the PH/PW schemas would indeed be very useful as well. If you encounter differences between the UPF schema in my repo and the one in qeschemas, perhaps |
sorry |
@pietrodelugas You mean we need to keep the
Sure, will do that. |
You are planning to replace UPF v2? By what? |
@ltalirz it's pratically already replaced by qe_pp.xsd schema, in the sense that any new change in the format (e.g. kinetic energy density, new names for functionals) will be implemented only in the new version.
given that the current changes are mostly aesthetic all the work of in the documentation of @unkcpz can be directly reused in the new schema. Also please consider to add the new changes directly in the new format. |
Ah, I see. |
There is no "official" name for the new format, but UPF v.3 looks like a reasonable choice. The state of the art is as follows:
In principle I agree that it would be preferable to document v.3, using the existing schema. Since however the differences between v.2 and v.3 are relatively minor and straightforward, we may also consider documenting the v.2 schema and porting the information into the v.3 schema later. By the way: a few days ago I had started to review the documentation of v.2 because what is available is in part incomplete, in part obsolete. Attached what I have done. |
Hi @ltalirz @pietrodelugas @giannozz, thanks a lot for the information. During the implementation I come up with some questions and think it worth to discuss:
@pietrodelugas can you provide a new version of UPF file so I can test the schema is correct. |
sorry @unkcpz the delay. |
I move the schema from https://github.com/ltalirz/upf-schema to this repository as
qe_pp-v2.xsd
, update the latest schema with with annotations and format asqe_pp-v3.xsd
.Moreover, I generate the documentation and serve it on ghpage.
Please check the example from https://unkcpz.github.io/qeschemas/.
@ltalirz @pietrodelugas If this is what we need, I will keep on adding the PH/PW schema doc to the ghpage. Let me know what your thoughts.