warning: usage of `Iterator::fold` on a type that implements `Try`
    --> halo2_proofs/src/dev.rs:1066:30
     |
1066 | ...                   .fold(Ok(()), |acc, res| acc.and(res))
     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
     = note: `-W clippy::manual-try-fold` implied by `-W clippy::all`

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:414:33
    |
414 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:371:33
    |
371 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/dev/cost.rs:328:33
    |
328 |             _marker: PhantomData::default(),
    |                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly.rs:174:22
    |
174 |                 .zip(inv_denoms.into_iter())
    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:642:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly.rs:159:14
    |
159 |         .zip(assigned_denominators.into_iter())
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:642:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/poly/multiopen/prover.rs:105:58
    |
105 |     let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold(
    |                                                          ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:642:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: use of `default` to create a unit struct
   --> halo2_proofs/src/poly/evaluator.rs:124:36
    |
124 |             _evaluator: PhantomData::default(),
    |                                    ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct
  --> halo2_proofs/src/poly/evaluator.rs:78:36
   |
78 |             _evaluator: PhantomData::default(),
   |                                    ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
   = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/plonk/verifier.rs:319:25
    |
319 | /                         lookups
320 | |                             .iter()
321 | |                             .flat_map(move |p| p.queries(vk, x))
322 | |                             .into_iter(),
    | |________________________________________^
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:523:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing the `.into_iter()`
    |
319 ~                         lookups
320 +                             .iter()
321 ~                             .flat_map(move |p| p.queries(vk, x)),
    |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/plonk/verifier.rs:259:25
    |
259 | /                         lookups
260 | |                             .iter()
261 | |                             .zip(vk.cs.lookups.iter())
262 | |                             .flat_map(move |(p, argument)| {
...   |
275 | |                             })
276 | |                             .into_iter(),
    | |________________________________________^
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:523:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing the `.into_iter()`
    |
259 ~                         lookups
260 +                             .iter()
261 +                             .zip(vk.cs.lookups.iter())
262 +                             .flat_map(move |(p, argument)| {
263 +                                 p.expressions(
264 +                                     l_0,
265 +                                     l_last,
266 +                                     l_blind,
267 +                                     argument,
268 +                                     theta,
269 +                                     beta,
270 +                                     gamma,
271 +                                     advice_evals,
272 +                                     fixed_evals,
273 +                                     instance_evals,
274 +                                 )
275 ~                             }),
    |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/plonk/prover.rs:707:24
    |
707 |                 .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter())
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:523:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/plonk/prover.rs:581:28
    |
581 |                     .chain(permutation_expressions.into_iter())
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:523:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/plonk/prover.rs:547:14
    |
547 |         .zip(lookup_expressions.into_iter())
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:642:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/plonk/prover.rs:546:14
    |
546 |         .zip(permutation_expressions.into_iter())
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:642:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
    --> halo2_proofs/src/plonk/circuit.rs:1261:22
     |
1261 |                 .zip(degrees.into_iter())
     |                      ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees`
     |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
    --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:642:12
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_proofs/src/plonk/circuit.rs:893:18
    |
893 |             .zip(self.constraints.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:642:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-W clippy::useless-conversion` implied by `-W clippy::all`

warning: an array of `Range` that is only one element
   --> halo2_gadgets/src/utilities.rs:407:47
    |
407 |         decompose(pallas::Base::random(rng), &[0..255]);
    |                                               ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
    = note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all`
help: if you wanted a `Vec` that contains the entire range, try
    |
407 |         decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>());
    |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 255, try
    |
407 |         decompose(pallas::Base::random(rng), &[0; 255]);
    |                                                ~~~~~~

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:127:34
    |
127 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:118:34
    |
118 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:103:34
    |
103 |             _phantom: PhantomData::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct
  --> halo2_gadgets/src/utilities/lookup_range_check.rs:52:38
   |
52 |                 _phantom: PhantomData::default(),
   |                                      ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_gadgets/src/sinsemilla.rs:694:48
    |
694 | ...                   .chain(right.into_iter()),
    |                              ^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `right`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:523:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_gadgets/src/sinsemilla.rs:693:48
    |
693 | ...                   .chain(left.into_iter())
    |                              ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `left`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/2ce543cc5acce60622e35acdca59be4547590567/library/core/src/iter/traits/iterator.rs:523:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-W clippy::useless-conversion` implied by `-W clippy::all`

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/sinsemilla/primitives.rs:344:31
    |
344 |         let mut os_rng = OsRng::default();
    |                               ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs