Only initialize RepeaterBook State ID if record has a RepeaterBook ID #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2024 14:06
The previous code was overzealous and initialized all missing RepeaterBook State ID fields to Washington (53). This had the unintended consequence of initializing the field for all repeaters that are not in RepeaterBook (including those outside of Washington). This change resets the state id for all repeaters w/o RepeterBook IDs to null and updates the initialization code to: - Prefer any existing RepeaterBook State ID - Only initialize the state id to Washington (53) if the record has a RepeaterBook ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was overzealous and initialized all missing RepeaterBook State ID fields to Washington (53). This had the unintended consequence of initializing the field for all repeaters that are not in RepeaterBook (including those outside of Washington).
This change resets the state id for all repeaters w/o RepeterBook IDs to null and updates the initialization code to:
Prefer any existing RepeaterBook State ID
Only initialize the state id to Washington (53) if the record has a RepeaterBook ID.