Fix export as Wiki example #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added ampersand escaping to also avoid faulty interpretation as HTML entity
a740g
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just fixes an escaping issue unveiled by the code example provided on the Wiki page https://qb64phoenix.com/qb64wiki/index.php/WAVE , some of the MML music in the DATA lines happend to build the
<b>combo, which the wiki interpreted as the HTML tag for bold text.Note that this issue only happend because the DATA content is not quoted in that example, one more reason to always use quotes, if the DATA element is not of pure numeric nature.
HTML export already used the proper escaping, the RTF format and Forum Codeboxes don't have the problem.