-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio queue manager, solution for #292 #462
Open
sockheadrps
wants to merge
19
commits into
PythonistaGuild:master
Choose a base branch
from
sockheadrps:AudioQueueManager
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Audio queue manager, solution for #292 #462
sockheadrps
wants to merge
19
commits into
PythonistaGuild:master
from
sockheadrps:AudioQueueManager
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for automatic detetction of local audio files' sample rate and audio channels so the files play correctly
…om audio files. Added setters for rate and channel to expose them incase the meta data is incorrect.
…om audio files. Added setters for rate and channel to expose them incase the meta data is incorrect.
chillymosh
reviewed
Jul 9, 2024
…hat didn't need to be coroutines, updated example
sockheadrps
force-pushed
the
AudioQueueManager
branch
from
July 10, 2024 05:42
1438923
to
2a739ed
Compare
chillymosh
reviewed
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #292
I added queuemanager.py to ext.sounds, which is a class that wraps the audio player and exposes common music queue functionality that allows users to add sound files to a queue and gives them an API to interact with that queue to control audio,
Checklist