Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md to add a step regarding .env #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShadowFox88
Copy link

Description

This PR simply adds a section to the README.md instructions on setting up the application with docker. It lets users know that there is a .env.example to copy to .env.

On an unrelated note, for the redis.conf, there is no mention of a password within it, yet it says to edit the password for added security, should this not exist there?

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

@AbstractUmbra
Copy link
Collaborator

Hey, thanks for the PR and time spent on this.

I'm a bit hesitant to merge this, due to waiting on #60 which would ultimately supercede this. I'll have a talk with @LostLuma about timescales and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants