-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Better comments section #366
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 80.12% 80.20% +0.08%
==========================================
Files 63 63
Lines 2953 2996 +43
==========================================
+ Hits 2366 2403 +37
- Misses 587 593 +6 ☔ View full report in Codecov by Sentry. |
fix: Erlang cookie might be a dir: add rm -r fix!: linter email problem dev(comment): Added field to `Comment._by_file` refactor(comment): `comment.delete` now gets id as a parameter, instead of using the `request` object. fix: Better indication of errors on /comment endpoint feat: Comments now also show user's gravatar fix: Responsibility issues KNOWN BUG: Adding a new comment looks strange. KNOWN BUG: No migration for changing linter mail. KNOWN BUG: There is an edit button -- it doesn't work ATM.
const editButton = this.shadowRoot.querySelector('.edit-btn'); | ||
const commentId = this.getAttribute('data-comment-id'); | ||
editButton.addEventListener('click', () => { | ||
window.location.href = `/comments/${commentId}/edit`; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
TODO:
/comments?act=fetch&fileId=ID
logic to support avatarsEditing will follow the creation of the new md editor for adding new comments