Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better comments section #366

Merged
merged 10 commits into from
Mar 1, 2024
Merged

feat: Better comments section #366

merged 10 commits into from
Mar 1, 2024

Conversation

yammesicka
Copy link
Member

@yammesicka yammesicka commented Feb 26, 2024

TODO:

  • Fix RTL languages alignment (Can we find a good md parser that actually solves this? Two birds one stone)
  • Think of a good way to pass date+times (prolly ISO-8601), parse in JS, put both as formatted text and on tag
  • Do some more small finishes (can we get it a bit smaller? Maybe the avatar should be on the inline-start and only name & date in the top?)
  • Remove old tooltip logic
  • Change backend /comments?act=fetch&fileId=ID logic to support avatars
  • Add new comments section logic to the frontend
  • Support deleting the comments
  • Fix: Adding a new comment looks strange.
  • Fix: No migration for changing linter mail.

Editing will follow the creation of the new md editor for adding new comments

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 80.35714% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 80.20%. Comparing base (f982fec) to head (a3acd78).

Files Patch % Lines
lms/lmsdb/bootstrap.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   80.12%   80.20%   +0.08%     
==========================================
  Files          63       63              
  Lines        2953     2996      +43     
==========================================
+ Hits         2366     2403      +37     
- Misses        587      593       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devops/lms.yml Outdated Show resolved Hide resolved
@yammesicka yammesicka self-assigned this Feb 26, 2024
fix: Erlang cookie might be a dir: add rm -r
fix!: linter email problem
dev(comment): Added field to `Comment._by_file`
refactor(comment): `comment.delete` now gets id as a parameter, instead
                   of using the `request` object.
fix: Better indication of errors on /comment endpoint
feat: Comments now also show user's gravatar
fix: Responsibility issues

KNOWN BUG: Adding a new comment looks strange.
KNOWN BUG: No migration for changing linter mail.
KNOWN BUG: There is an edit button -- it doesn't work ATM.
const editButton = this.shadowRoot.querySelector('.edit-btn');
const commentId = this.getAttribute('data-comment-id');
editButton.addEventListener('click', () => {
window.location.href = `/comments/${commentId}/edit`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
@yammesicka yammesicka merged commit a43528e into master Mar 1, 2024
6 checks passed
@yammesicka yammesicka deleted the better-comments-section branch March 1, 2024 08:57
This was linked to issues Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a better looking comments Support markdown in comments
1 participant