WIP SpeedyMeetings2 #157

omrizhaki · 2021-01-30T01:38:49Z

No description provided.

sagizaidor · 2021-01-30T18:34:38Z

app/database/models.py

@@ -37,17 +37,26 @@ class User(Base):

    events = relationship("UserEvent", back_populates="participants")

+    speedy_meetings_enabled = Column(Boolean, default=False)
+
+    def has_speedy_meetings_enabled(self) -> bool:


מה המטרה שך הפנציה הזאת? למה לקרוא לה ולא פשוט לא user.speedy_meetings_enabled?

sagizaidor · 2021-01-30T18:40:47Z

app/database/models.py

@@ -57,6 +66,14 @@ class Event(Base):

    participants = relationship("UserEvent", back_populates="events")

+    def get_event_duration(self):


זה דבר נהוג להכניס פונקציות לModels ולא להוציא את זה לקבצים בinternal?
בדקת את זה לפני?

שואל באמת כי זה פעם ראשונה שאני רואה

yammesicka · 2021-01-31T05:11:05Z

This is a good start :) Keep going

omrizhaki added 3 commits January 30, 2021 02:56

fix: work with database

3ae432a

fix: flake8

f7f556c

fix: newfile

ca896f4

omrizhaki changed the base branch from main to develop January 30, 2021 01:39

omrizhaki added 5 commits January 30, 2021 03:41

fix: flake8

6380fe3

fix: again

a4fd927

fix: again2

8fe713d

fix: again3

2d04e8e

fix: again4

519f5f9

sagizaidor reviewed Jan 30, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP SpeedyMeetings2 #157

WIP SpeedyMeetings2 #157

omrizhaki commented Jan 30, 2021

sagizaidor Jan 30, 2021

sagizaidor Jan 30, 2021

yammesicka commented Jan 31, 2021

		@@ -57,6 +66,14 @@ class Event(Base):

		participants = relationship("UserEvent", back_populates="events")

		def get_event_duration(self):

WIP SpeedyMeetings2 #157

Are you sure you want to change the base?

WIP SpeedyMeetings2 #157

Conversation

omrizhaki commented Jan 30, 2021

sagizaidor Jan 30, 2021

Choose a reason for hiding this comment

sagizaidor Jan 30, 2021

Choose a reason for hiding this comment

yammesicka commented Jan 31, 2021