[StatsPerform] Bugfixes for tracking deserializer #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the correct coordinate system and pitch dimensions - Remove "BALL_OWNING_TEAM" flag - Metadata.periods should be a list, not a dict - Skip frames for which ball_state = DEAD when only_alive = True Fixes PySport#299.
probberechts
commented
Apr 12, 2024
| @@ -11,12 +11,23 @@ | |||
| def load( | |||
| meta_data: FileLike, # Stats Perform MA1 file - xml or json - single game, live data & lineups | |||
| raw_data: FileLike, # Stats Perform MA25 file - txt - tracking data | |||
| provider_name: str = "sportvu", | |||
There was a problem hiding this comment.
I am aware that this parameter could be confusing. Are there any ideas for a better name? Stats Perform distributes the tracking data from different systems and keeps the coordinate system of the original tracking data provider (SportVU, Tracab, SecondSpectrum, etc.). Hence, you must provide the name of the original provider of the data to know the coordinate system.
|
Superseded by #310. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
periodsfield of the metadata should be a list, not a dict.only_alive = True.