-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FoulComitted + Card for Wyscout v2 #261
Fix FoulComitted + Card for Wyscout v2 #261
Conversation
probberechts
commented
Dec 15, 2023
- No FoulComitted event was recorded when a card was given. To be consistent with the other data providers both a FoulCommittedEvent and CardEvent are recorded now.
- Adds CardQualifiers to the FoulCommittedEvent.
- No FoulComitted event was recorded when a card was given. To be consistent with the other data providers both a FoulCommittedEvent and CardEvent are recorded now. - Adds CardQualifiers to the FoulCommittedEvent.
Adds a prefix to the ID of synthetic events to avoid having multiple events with the same ID.
I made a few more changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. I left a few minor comments.
a69b89b
to
ea5715b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Great work @probberechts! Can you merge current master in and resolve conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Please resolve merge conflicts
f8a1750
to
170f6ea
Compare
170f6ea
to
38f6aba
Compare