Fix Wyscout deserialization of teams and players #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The structure of the Wyscout v2 test file does not correspond to the specs in the official documentation. This commit fixes the test file and adapts the deserializer accordingly. Fixes PySport#234
JanVanHaaren
approved these changes
Nov 19, 2023
JanVanHaaren
approved these changes
Nov 19, 2023
|
I noticed that this PR will break loading the Wyscout open data. The preprocessed version of this dataset in koenvo/wyscout-soccer-match-event-dataset would have to be updated as well. |
|
Thanks for this fix! Let me see how to update this on the open data part. Will probably need to generate a new set under a different directory in the repository and point kloppy to the new location. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure of the Wyscout v2 test file does not correspond to the specs in the official documentation. This commit fixes the test file and adapts the deserializer accordingly.
Fixes #234