Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bodypart qualifiers in StatsBomb clearance event #228

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix Bodypart qualifiers in StatsBomb clearance event #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions kloppy/infra/serializers/event/statsbomb/deserializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,22 +469,10 @@ def _parse_carry(carry_dict: Dict, fidelity_version: int) -> Dict:
}


def _parse_clearance(raw_event: Dict, events: List) -> Dict:
def _parse_clearance(clearance_dict: Dict) -> Dict:
qualifiers = []
if "related_events" in raw_event:
for event in events[-20:][::-1]:
if event.event_id == raw_event["related_events"][0]:
found_event = event
body_part_qualifiers = []
if "pass" in found_event.raw_event:
related_event_dict = found_event.raw_event["pass"]
body_part_qualifiers = _get_body_part_qualifiers(
related_event_dict
)

qualifiers.extend(body_part_qualifiers)
break

body_part_qualifiers = _get_body_part_qualifiers(clearance_dict)
qualifiers.extend(body_part_qualifiers)
return {"qualifiers": qualifiers}


Expand Down Expand Up @@ -858,7 +846,9 @@ def deserialize(self, inputs: StatsBombInputs) -> EventDataset:
new_events.append(shot_event)
elif event_type == SB_EVENT_TYPE_CLEARANCE:
clearance_event_kwargs = _parse_clearance(
raw_event=raw_event, events=events
# Old versions of the data (< v1.1) don't define extra
# attributes for clearances
clearance_dict=raw_event.get("clearance", {}),
)
clearance_event = self.event_factory.build_clearance(
result=None,
Expand Down