Merge pull request #279 from my-game-plan/feature/fix-wyscout-orienta…

…tion Fix Wyscout orientation
PySport · Jan 22, 2024 · 6013893 · 6013893
2 parents 3360c6e + 93d508a
commit 6013893
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/kloppy/infra/serializers/event/wyscout/deserializer_v2.py b/kloppy/infra/serializers/event/wyscout/deserializer_v2.py
@@ -712,7 +712,7 @@ def deserialize(self, inputs: WyscoutInputs) -> EventDataset:
             pitch_dimensions=transformer.get_to_coordinate_system().pitch_dimensions,
             score=None,
             frame_rate=None,
-            orientation=Orientation.BALL_OWNING_TEAM,
+            orientation=Orientation.ACTION_EXECUTING_TEAM,
             flags=None,
             provider=Provider.WYSCOUT,
             coordinate_system=transformer.get_to_coordinate_system(),

diff --git a/kloppy/infra/serializers/event/wyscout/deserializer_v3.py b/kloppy/infra/serializers/event/wyscout/deserializer_v3.py
@@ -684,7 +684,7 @@ def deserialize(self, inputs: WyscoutInputs) -> EventDataset:
             pitch_dimensions=transformer.get_to_coordinate_system().pitch_dimensions,
             score=None,
             frame_rate=None,
-            orientation=Orientation.BALL_OWNING_TEAM,
+            orientation=Orientation.ACTION_EXECUTING_TEAM,
             flags=None,
             provider=Provider.WYSCOUT,
             coordinate_system=transformer.get_to_coordinate_system(),

diff --git a/kloppy/tests/test_wyscout.py b/kloppy/tests/test_wyscout.py
@@ -16,6 +16,7 @@
     GoalkeeperActionType,
     CardQualifier,
     CardType,
+    Orientation,
 )
 
 from kloppy import wyscout
@@ -52,6 +53,9 @@ def dataset(self, event_v2_data) -> EventDataset:
             data_version="V2",
         )
         assert dataset.dataset_type == DatasetType.EVENT
+        assert (
+            dataset.metadata.orientation == Orientation.ACTION_EXECUTING_TEAM
+        )
         return dataset
 
     def test_shot_event(self, dataset: EventDataset):
@@ -130,6 +134,9 @@ def dataset(self, event_v3_data: Path) -> EventDataset:
             data_version="V3",
         )
         assert dataset.dataset_type == DatasetType.EVENT
+        assert (
+            dataset.metadata.orientation == Orientation.ACTION_EXECUTING_TEAM
+        )
         return dataset
 
     def test_coordinates(self, dataset: EventDataset):