-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/action manager qicon import #3
base: 5.0.x_dev
Are you sure you want to change the base?
Feature/action manager qicon import #3
Conversation
The code first test if the pixel map exists in Pymodaq's library and checks for Qt afterwards.
…om/Ashwolaa/pymodaq_gui into feature/action_manager_QIconImport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is still some cleaning to do and a try/except statement to add. Also could you modify the docstring to explain what are the options for the icon_name:
- png file name in the icon_library
- enum name from the QIcon.ThemeIcon (Qt>=6.7)
- a Path to a png file
Well I did the review, there are things to do on your side ;-) |
Qt6 comes with its own library for icons.
This patch now allow direct import of Qt's icon with the action manager either loaded it directly as icons or through their keyword
Syntax goes as: